Verify llvm-needs-components are not empty and match the --target value #144042
+256
−84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently discovered a test with an empty
llvm-needs-components
entry (fixed in rust-lang/rust#149178) which meant that it didn't work correctly when building Rust with a limited set of LLVM targets.This change makes a pair of improvements to prevent this issue from creeping in again:
compiletest
will now raise an error if there is an empty value.target_specific_tests
tidy checker to map targets to LLVM components, to verify that any existingllvm-needs-components
contains the target being used.I also fixed all the issues flagged by the improved tidy checker.