Skip to content

compiler-builtins subtree update #144154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 21, 2025
Merged

compiler-builtins subtree update #144154

merged 13 commits into from
Jul 21, 2025

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Jul 18, 2025

Subtree update of compiler-builtins to rust-lang/compiler-builtins@2cdde03.

Created using https://github.com/rust-lang/josh-sync.

Fixes: #144076

r? @ghost

Kobzol and others added 13 commits July 8, 2025 08:56
Pick up the latest version of iai-callgrind, which includes some output
improvements.

Changelog: https://github.com/iai-callgrind/iai-callgrind/releases
This CI workflow will run the https://github.com/rust-lang/josh-sync
tool on Mondays and Thursdays. It will try to do a pull (sync stdarch
changes from rust-lang/rust into this repository). When it runs, three
things can happen:
- There are no rustc changes to be pulled, the bot does nothing.
- There are some new changes to be pulled. In that case, the bot will
either open or update an existing PR titled "Rustc pull update" on this
repository with the changes. After the PR is merged, we should ideally
do the opposite sync (push) manually.
- The pull fails (usually because of a merge conflict), or the bot
determines that a pull PR has been opened for more than a week without
being merged. In that case, it will post a ping to
https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/compiler-builtins.20subtree.20sync.20automation/with/528482375.
```text
warning: function `f32_to_bits` is never used
   --> libm/src/math/support/float_traits.rs:367:14
    |
367 | pub const fn f32_to_bits(x: f32) -> u32 {
    |              ^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: function `f64_to_bits` is never used
   --> libm/src/math/support/float_traits.rs:381:14
    |
381 | pub const fn f64_to_bits(x: f64) -> u64 {
    |              ^^^^^^^^^^^

warning: `libm` (lib) generated 2 warnings
```

This is a false positive, see RUST-144060.
This alias was added in 9897bfb8a ("Fix memset arguments for MSP430
target"), which predates `core::ffi`. Now that it exists we can just use
`core::ffi::c_int`.
Fix the return type of `memcmp` and `bcmp` builtin functions on targets
with a `c_int` other than `i32`.

Linked issue: rust-lang#144076
This updates the rust-version file to 8231065.
Pull recent changes from https://github.com/rust-lang/rust via Josh.

Upstream ref: 8231065
Filtered ref: e13c0be8f13737c64082b89ce834546079767ac4

This merge was created using https://github.com/rust-lang/josh-sync.
@rustbot rustbot added A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025
@tgross35
Copy link
Contributor Author

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jul 18, 2025

📌 Commit 3f04631 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 18, 2025
@bors
Copy link
Collaborator

bors commented Jul 21, 2025

⌛ Testing commit 3f04631 with merge 3f9f20f...

@bors
Copy link
Collaborator

bors commented Jul 21, 2025

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 3f9f20f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2025
@bors bors merged commit 3f9f20f into rust-lang:master Jul 21, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 21, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6781992 (parent) -> 3f9f20f (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 3f9f20f71dd945fe7d044e274094a53c90788269 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-android: 2508.1s -> 2874.4s (14.6%)
  2. x86_64-apple-1: 9564.2s -> 8532.8s (-10.8%)
  3. dist-x86_64-apple: 8418.1s -> 7652.1s (-9.1%)
  4. dist-aarch64-windows-gnullvm: 4444.9s -> 4811.2s (8.2%)
  5. x86_64-mingw-1: 8792.7s -> 9344.3s (6.3%)
  6. x86_64-gnu-llvm-19-2: 5966.6s -> 5603.3s (-6.1%)
  7. dist-ohos-aarch64: 4132.9s -> 4377.0s (5.9%)
  8. dist-aarch64-linux: 5703.4s -> 6016.2s (5.5%)
  9. i686-gnu-2: 5376.7s -> 5671.0s (5.5%)
  10. x86_64-rust-for-linux: 2579.5s -> 2717.2s (5.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@tgross35 tgross35 deleted the update-builtins branch July 21, 2025 16:40
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3f9f20f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary 2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.4%, 2.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (primary -2.6%, secondary -1.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.6% [1.6%, 1.6%] 1
Improvements ✅
(primary)
-2.6% [-2.6%, -2.6%] 1
Improvements ✅
(secondary)
-3.0% [-3.5%, -2.5%] 2
All ❌✅ (primary) -2.6% [-2.6%, -2.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.321s -> 465.766s (0.10%)
Artifact size: 374.50 MiB -> 374.60 MiB (0.03%)

Muscraft pushed a commit to Muscraft/rust that referenced this pull request Jul 21, 2025
compiler-builtins subtree update

Subtree update of `compiler-builtins` to rust-lang/compiler-builtins@2cdde03.

Created using https://github.com/rust-lang/josh-sync.

Fixes: rust-lang#144076

r? `@ghost`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array comparisons don't work on AVR - memcmp should return a c_int
6 participants