Skip to content

Consider parent predicates in ImpossiblePredicates pass. #144233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

Consider parent predicates in ImpossiblePredicates pass. #144233

merged 3 commits into from
Jul 23, 2025

Conversation

cjgillot
Copy link
Contributor

@cjgillot cjgillot commented Jul 20, 2025 •
edited by rustbot
Loading

This pass is double edged. It avoids some ICEs (yay!) but also degrades diagnostics from constant evaluation.

Fixes #121363
Fixes #131507
Fixes #140100
Fixes #140365

@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbot
Copy link
Collaborator

rustbot commented Jul 20, 2025

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@compiler-errors
Copy link
Member

Should also queue a perf run once we're elaborating again.

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2025
@bors
Copy link
Collaborator

bors commented Jul 22, 2025

⌛ Trying commit b1d88ba with merge a338cd3...

bors added a commit that referenced this pull request Jul 22, 2025
@bors
Auto merge of #144233 - cjgillot:unsat-mir, r=<try>
a338cd3 
Consider parent predicates in ImpossiblePredicates pass.

This pass is double edged. It avoids some ICEs (yay!) but also degrades diagnostics from constant evaluation.

Fixes #121363
Fixes #131507
Fixes #140100
Fixes #140365
@bors
Copy link
Collaborator

bors commented Jul 22, 2025

☀️ Try build successful - checks-actions
Build commit: a338cd3 (a338cd336c717aa41973ab426315a9b277708d27)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a338cd3): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.1%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.5%] 1
Improvements ✅
(primary)		 -1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)		 -0.9% [-0.9%, -0.9%] 1
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Cycles

Results (primary -2.8%, secondary -4.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.8% [-2.9%, -2.8%] 2
Improvements ✅
(secondary)		 -4.9% [-4.9%, -4.9%] 1
All ❌✅ (primary) -2.8% [-2.9%, -2.8%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 465.536s -> 464.023s (-0.33%)
Artifact size: 374.60 MiB -> 374.61 MiB (0.00%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 22, 2025
@oli-obk
Copy link
Contributor

oli-obk commented Jul 22, 2025

@bors r+

r? @oli-obk

@bors
Copy link
Collaborator

bors commented Jul 22, 2025

📌 Commit b1d88ba has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 22, 2025
@bors
Copy link
Collaborator

bors commented Jul 23, 2025

⌛ Testing commit b1d88ba with merge ace6330...

@bors
Copy link
Collaborator

bors commented Jul 23, 2025

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing ace6330 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 23, 2025
@bors bors merged commit ace6330 into rust-lang:master Jul 23, 2025
12 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 29a5872 (parent) -> ace6330 (this PR)

Test differences

Show 16 test diffs

Stage 1

  • [crashes] tests/crashes/121363.rs: pass -> [missing] (J1)
  • [crashes] tests/crashes/131507.rs: pass -> [missing] (J1)
  • [crashes] tests/crashes/140100.rs: pass -> [missing] (J1)
  • [crashes] tests/crashes/140365.rs: pass -> [missing] (J1)
  • [ui] tests/ui/mir/meaningless-bound.rs: [missing] -> pass (J1)
  • [ui] tests/ui/trivial-bounds/everybody-copies.rs: [missing] -> pass (J1)
  • [ui] tests/ui/trivial-bounds/two-sized-strs.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/mir/meaningless-bound.rs: [missing] -> pass (J0)
  • [ui] tests/ui/trivial-bounds/everybody-copies.rs: [missing] -> pass (J0)
  • [ui] tests/ui/trivial-bounds/two-sized-strs.rs: [missing] -> pass (J0)
  • [crashes] tests/crashes/121363.rs: pass -> [missing] (J2)
  • [crashes] tests/crashes/131507.rs: pass -> [missing] (J2)
  • [crashes] tests/crashes/140100.rs: pass -> [missing] (J2)
  • [crashes] tests/crashes/140365.rs: pass -> [missing] (J2)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ace633090349fc5075b5b0d56294de985e7d1191 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 5902.7s -> 8027.3s (36.0%)
  2. aarch64-apple: 4903.2s -> 6023.9s (22.9%)
  3. x86_64-apple-2: 5435.2s -> 4238.8s (-22.0%)
  4. dist-apple-various: 8483.6s -> 6619.2s (-22.0%)
  5. dist-x86_64-apple: 10984.7s -> 9585.4s (-12.7%)
  6. dist-aarch64-apple: 6493.7s -> 7147.6s (10.1%)
  7. x86_64-gnu-tools: 3451.6s -> 3144.9s (-8.9%)
  8. pr-check-1: 1671.4s -> 1549.9s (-7.3%)
  9. aarch64-msvc-2: 5064.9s -> 5409.5s (6.8%)
  10. dist-arm-linux-musl: 5361.9s -> 5656.5s (5.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@cjgillot cjgillot deleted the unsat-mir branch July 23, 2025 23:44
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ace6330): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.2%, secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.5% [2.5%, 2.6%] 2
Improvements ✅
(primary)		 -2.2% [-3.5%, -1.0%] 2
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.2% [-3.5%, -1.0%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.271s -> 468.354s (0.02%)
Artifact size: 374.67 MiB -> 374.67 MiB (-0.00%)

@cjgillot cjgillot mentioned this pull request Jul 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
7 participants
@cjgillot @rustbot @compiler-errors @rust-timer @bors @oli-obk @davidtwco