Skip to content

tests/ui/issues/: The Issues Strike Back [3/N] #144400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

tests/ui/issues/: The Issues Strike Back [3/N] #144400

wants to merge 2 commits into from

Conversation

Kivooeo
Copy link
Contributor

@Kivooeo Kivooeo commented Jul 24, 2025

Some tests/ui/issues/ housekeeping, to trim down number of tests directly under tests/ui/issues/. Part of #133895.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jul 24, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@bors
Copy link
Collaborator

bors commented Jul 26, 2025

☔ The latest upstream changes (presumably #144488) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu
jieyouxu requested changes Aug 5, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, some nits

tests/ui/extern/macro-use-extern-std-14330.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: yeet this, this was originally testing #![feature(phase)] that was yeeted.

tests/ui/lifetimes/return-reference-local-variable-13497-2.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: does this still need the -2?

tests/ui/macros/assert-mismatched-types-14091.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: remove this test, I'm like 90% sure this already regressed in what it was testing as original reproducer is very whitespace sensitive, i.e. #14091

tests/ui/macros/assert-unary-operator-14091-2.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: also remove, whitespace was changed since a long time ago as well

tests/ui/modules/use-shadowing-14082.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: resolve/

tests/ui/pattern/array-length-mismatch-verbose-13482-2.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: don't need the -2 then

tests/ui/traits/generic-trait-bound-14382.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: inference/.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was moved by @Oneirical and it's now tests/ui/type-inference/float-type-inference-unification-14382.rs so I keep it as it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh if that's the case, yeet this duplicate test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After I did git pull --rebase to remove conflicts its already unified our tests and keep their, so I just removed their comment from bottom, imo type-inference/ is fine here (https://github.com/rust-lang/rust/pull/144400/files#diff-385ae3df0488b90afc0e919de63c4398ae3f831569ce53818649706c5349afb8)

tests/ui/traits/matcher-lifetime-inference-14919.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: inference/

tests/ui/traits/pointer-type-impls-14254.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: resolve/

tests/ui/traits/reader-wrapper-trait-14901.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: maybe lifetimes/ or bounds/ if we have such directory

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu requested changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kivooeo @rustbot @bors @jieyouxu