Skip to content

Rollup of 4 pull requests #144528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 27, 2025
Merged

Rollup of 4 pull requests #144528

merged 13 commits into from
Jul 27, 2025

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Jul 27, 2025

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

xizheyin and others added 13 commits July 24, 2025 23:46
…nkov

Optimize performance by inline in macro hygiene system

I inline some small method in `rustc_span/src/hygiene.rs` and so on.
move uefi test to run-make

Turn the `uefi` test into a more standard `run-make` test, and execute it using the `test-various` CI job like before.

This is just a straightforward translation of the python code, but using `run-make` to supply the target (hence the 3 separate calls in the docker file).

r? ```@jieyouxu```
cc ```@nicholasbishop```

try-job: test-various
Unify LLVM ctlz/cttz intrinsic generation

The type signature for `llvm.ctlz` is the same as the one for `llvm.cttz`, which enables a small simplification.
@rustbot rustbot added A-CI Area: Our Github Actions CI A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jul 27, 2025
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jul 27, 2025

📌 Commit dd6e4a9 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2025
@bors
Copy link
Collaborator

bors commented Jul 27, 2025

⌛ Testing commit dd6e4a9 with merge eed187c...

@bors
Copy link
Collaborator

bors commented Jul 27, 2025

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing eed187c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 27, 2025
@bors bors merged commit eed187c into rust-lang:master Jul 27, 2025
11 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jul 27, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#144226 Do not assert layout in KnownPanicsLint. 1da48a3d01f078e9ab8d0323ae249acb1455d2ee (link)
#144385 Optimize performance by inline in macro hygiene system 48dab25f338de270b2a83e5575607d0d0f941191 (link)
#144454 move uefi test to run-make dd8f959594479d58daa34133264cbbf8c65c3e74 (link)
#144455 Unify LLVM ctlz/cttz intrinsic generation 506c507afa6a369c210e04d3b44e9eab8f7759dc (link)

previous master: 86ef320294

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 86ef320 (parent) -> eed187c (this PR)

Test differences

Show 33 test diffs

Stage 1

  • [crashes] tests/crashes/121176.rs: pass -> [missing] (J1)
  • [crashes] tests/crashes/129109.rs: pass -> [missing] (J1)
  • [crashes] tests/crashes/130970.rs: pass -> [missing] (J1)
  • [crashes] tests/crashes/131347.rs: pass -> [missing] (J1)
  • [run-make] tests/run-make/uefi-qemu: [missing] -> ignore (only executed when the operating system is uefi) (J1)
  • [ui] tests/ui/mir/static-by-value-dyn.rs: [missing] -> pass (J1)
  • [ui] tests/ui/mir/static-by-value-slice.rs: [missing] -> pass (J1)
  • [ui] tests/ui/mir/static-by-value-str.rs: [missing] -> pass (J1)
  • [ui] tests/ui/mir/unsized-extern-static.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/mir/static-by-value-dyn.rs: [missing] -> ignore (ignored if rustc wasn't built with debug assertions) (J0)
  • [ui] tests/ui/mir/static-by-value-slice.rs: [missing] -> pass (J2)
  • [ui] tests/ui/mir/static-by-value-str.rs: [missing] -> pass (J2)
  • [ui] tests/ui/mir/unsized-extern-static.rs: [missing] -> pass (J2)
  • [run-make] tests/run-make/uefi-qemu: [missing] -> ignore (only executed when the operating system is uefi) (J3)
  • [crashes] tests/crashes/129109.rs: pass -> [missing] (J4)
  • [crashes] tests/crashes/130970.rs: pass -> [missing] (J4)
  • [crashes] tests/crashes/131347.rs: pass -> [missing] (J4)
  • [crashes] tests/crashes/121176.rs: pass -> [missing] (J5)
  • [run-make] tests/run-make/uefi-qemu: [missing] -> pass (J6)
  • [crashes] tests/crashes/121176.rs: ignore (ignored if rustc wasn't built with debug assertions) -> [missing] (J7)
  • [ui] tests/ui/mir/static-by-value-dyn.rs: [missing] -> pass (J8)

Additionally, 12 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard eed187cfce988dd669b7d9161f324433e64358ee --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-apple-1: 9432.7s -> 7178.2s (-23.9%)
  2. pr-check-2: 2201.6s -> 2666.3s (21.1%)
  3. x86_64-apple-2: 5349.6s -> 4320.0s (-19.2%)
  4. i686-gnu-1: 7368.3s -> 8734.6s (18.5%)
  5. dist-apple-various: 7823.2s -> 6381.9s (-18.4%)
  6. x86_64-gnu-llvm-19: 2445.0s -> 2879.4s (17.8%)
  7. x86_64-rust-for-linux: 2557.7s -> 2957.2s (15.6%)
  8. i686-gnu-2: 5323.8s -> 5998.3s (12.7%)
  9. x86_64-gnu-aux: 5904.4s -> 6624.6s (12.2%)
  10. aarch64-gnu-llvm-19-2: 2248.0s -> 2490.0s (10.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (eed187c): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.1%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-2.8%, -1.8%] 3
All ❌✅ (primary) - - 0

Cycles

Results (primary 2.2%, secondary 10.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)
10.3% [10.3%, 10.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.671s -> 468.356s (0.15%)
Artifact size: 376.75 MiB -> 376.74 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants