Skip to content

Rehome 21 tests/ui/issues/ tests to other subdirectories under tests/ui/ #144548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Oneirical
Copy link
Contributor

#143902 divided into smaller, easier to review chunks.

Part of #133895

Methodology:

  1. Refer to the previously written tests/ui/SUMMARY.md
  2. Find an appropriate category for the test, using the original issue thread and the test contents.
  3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
  4. Rename the tests to make their purpose clearer

Inspired by the methodology that @Kivooeo was using.

r? @jieyouxu

@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2025

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 27, 2025
@rust-log-analyzer

This comment has been minimized.

@Oneirical Oneirical changed the title Rehome 30 tests/ui/issues/ tests to other subdirectories under tests/ui/ Rehome 21 tests/ui/issues/ tests to other subdirectories under tests/ui/ Jul 27, 2025
@Oneirical Oneirical force-pushed the uncountable-integer-2 branch from 6b978c5 to 6b48664 Compare July 27, 2025 21:56
@rustbot
Copy link
Collaborator

rustbot commented Jul 27, 2025

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@rust-log-analyzer

This comment has been minimized.

@Oneirical Oneirical force-pushed the uncountable-integer-2 branch from 6b48664 to a9ed9a4 Compare July 27, 2025 22:44
@jieyouxu
Copy link
Member

For future PRs like this where you have both moves and edits, can you make sure to split the changes into two commits, with commit 1 being move-only, and commit 2 being edits? This is intended to make it easier to navigate git history. I wouldn't worry so much about PRs you already have opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants