-
Notifications
You must be signed in to change notification settings - Fork 13.6k
stall ConstArgHasType
in compute_goal_fast_path
#144702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stall ConstArgHasType
in compute_goal_fast_path
#144702
Conversation
@bors2 try @rust-timer queue After this experiment I want to also see if we should do a fast path for param-env lookup and structually matching the ty. |
This comment has been minimized.
This comment has been minimized.
…try> stall `ConstArgHasType` in `compute_goal_fast_path`
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (b777317): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.5%, secondary 3.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 469.342s -> 470.258s (0.20%) |
r? @SparrowLii rustbot has assigned @SparrowLii. Use |
This is kinda whatever but I think it can still land because it seems useful in the abstract sense and likely not to make things slower in a concrete sense. r? lcnr |
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
Given the perf impact 🤔 @bors r+ rollup=always |
Rollup of 6 pull requests Successful merges: - #144688 (Uniform `enter_trace_span!` and add documentation) - #144702 (stall `ConstArgHasType` in `compute_goal_fast_path`) - #144711 (Consider operator's span when computing binop expr span) - #144712 (Deduplicate `IntTy`/`UintTy`/`FloatTy`.) - #144726 (merge rustc_attr_data_structures into rustc_hir) - #144733 (fix: Match width of ascii and unicode secondary file start) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #144702 - compiler-errors:stall-const-arg-has-type, r=lcnr stall `ConstArgHasType` in `compute_goal_fast_path` I'm having major deja-vu about this; I thought that already implemented this but 🤷 maybe not.
Rollup of 6 pull requests Successful merges: - rust-lang/rust#144688 (Uniform `enter_trace_span!` and add documentation) - rust-lang/rust#144702 (stall `ConstArgHasType` in `compute_goal_fast_path`) - rust-lang/rust#144711 (Consider operator's span when computing binop expr span) - rust-lang/rust#144712 (Deduplicate `IntTy`/`UintTy`/`FloatTy`.) - rust-lang/rust#144726 (merge rustc_attr_data_structures into rustc_hir) - rust-lang/rust#144733 (fix: Match width of ascii and unicode secondary file start) r? `@ghost` `@rustbot` modify labels: rollup
I'm having major deja-vu about this; I thought that already implemented this but 🤷 maybe not.