Rehome 30 tests/ui/issues/ tests to other subdirectories under tests/ui/ [#4 of Batch #2]
#145897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
rustbot
added
S-waiting-on-review
|
This PR modifies |
jieyouxu
requested changes
Sep 5, 2025
tests/ui/parser/character-indexing-bug-in-splice-lines-69130.rs
Outdated
Show resolved
Hide resolved
rustbot
added
S-waiting-on-author
|
Also tiny nit: can you refrain from at-mentioning Kivo in PR description
(just remove the
is fine. Otherwise, they will get pinged for each of such PRs. |
Oneirical
force-pushed
the
uncountable-integer-11
branch
from
f390533 to
37c9001
Compare
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #147074) made this pull request unmergeable. Please resolve the merge conflicts. |
Oneirical
force-pushed
the
uncountable-integer-11
branch
from
37c9001 to
22b9b97
Compare
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
uncountable-integer-11
branch
from
22b9b97 to
f957ddb
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
You can r=me once PR CI is green. |
|
✌️ @Oneirical, you can now approve this pull request! If @jieyouxu told you to " |
This comment has been minimized.
This comment has been minimized.
Oneirical
force-pushed
the
uncountable-integer-11
branch
from
f957ddb to
6ca6981
Compare
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 12, 2025
Rollup of 8 pull requests Successful merges: - #138799 (core: simplify `Extend` for tuples) - #145897 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#4 of Batch #2]) - #146692 (Save x.py's help text for saving output time) - #147240 (Add an ACP list item to the library tracking issue template) - #147246 (Explain not existed key in BTreeMap::split_off) - #147393 (Extract most code from `define_feedable!`) - #147503 (Fix documentation of Instant::now on mac) - #147549 (Replace `LLVMRustContextCreate` with normal LLVM-C API calls) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Oct 12, 2025
Rollup merge of #145897 - Oneirical:uncountable-integer-11, r=jieyouxu Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#4 of Batch #2] Part of #133895 Methodology: 1. Refer to the previously written `tests/ui/SUMMARY.md` 2. Find an appropriate category for the test, using the original issue thread and the test contents. 3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers) 4. Rename the tests to make their purpose clearer Inspired by the methodology that `@Kivooeo` was using. r? `@jieyouxu`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #133895
Methodology:
tests/ui/SUMMARY.mdInspired by the methodology that @Kivooeo was using.
r? @jieyouxu