Move #[rustc_coherence_is_core] to the crate_level file
#146647
Merged
+21
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
|
jdonszelmann
force-pushed
the
move-coherence-is-core
branch
from
894995b to
dfbaf7e
Compare
Urgau
approved these changes
Sep 16, 2025
|
r? Urgau |
bors
added
S-waiting-on-bors
|
thanks for the quick review @Urgau! <3 |
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 17, 2025
…e, r=Urgau Move `#[rustc_coherence_is_core]` to the `crate_level` file I implemented this one without realizing it already was since it was (in my opinion) in the wrong file and implemented in a batch of all non-crate-level attributes. This commit just cleans it up slightly and moves it. Should be trivial r? `@oli-obk`
bors
added a commit
that referenced
this pull request
Sep 17, 2025
Rollup of 9 pull requests Successful merges: - #144871 (Stabilize `btree_entry_insert` feature) - #145181 (remove FIXME block from `has_significant_drop`, it never encounters inference variables) - #145838 (don't apply temporary lifetime extension rules to non-extended `super let`) - #146259 (Suggest removing Box::new instead of unboxing it) - #146410 (Iterator repeat: no infinite loop for `last` and `count`) - #146460 (Add tidy readme) - #146581 (Detect attempt to use var-args in closure) - #146588 (tests/run-make: Update list of statically linked musl targets) - #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file) r? `@ghost` `@rustbot` modify labels: rollup
|
☔ The latest upstream changes (presumably #146666) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
jdonszelmann
force-pushed
the
move-coherence-is-core
branch
from
dfbaf7e to
205189c
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r=urgau |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 17, 2025
Rollup of 7 pull requests Successful merges: - #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation) - #146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations) - #146536 (clean up several trait related UI tests) - #146598 (Make llvm_enzyme a regular cargo feature) - #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file) - #146654 (Do not use `git -C dir`) - #146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 18, 2025
Rollup merge of #146647 - jdonszelmann:move-coherence-is-core, r=urgau Move `#[rustc_coherence_is_core]` to the `crate_level` file I implemented this one without realizing it already was since it was (in my opinion) in the wrong file and implemented in a batch of all non-crate-level attributes. This commit just cleans it up slightly and moves it. Should be trivial r? `@oli-obk`
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented this one without realizing it already was since it was (in my opinion) in the wrong file and implemented in a batch of all non-crate-level attributes. This commit just cleans it up slightly and moves it. Should be trivial
r? @oli-obk