-
Notifications
You must be signed in to change notification settings - Fork 13.8k
fix bug in proc macro derive diagnostics #146657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix bug in proc macro derive diagnostics #146657
Conversation
ca8d53a
to
665024c
Compare
This comment has been minimized.
This comment has been minimized.
665024c
to
5319b5e
Compare
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in diagnostic error codes |
5319b5e
to
548489e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error code changes look good to me, thanks! Gonna let estebank handle the rest. :)
☔ The latest upstream changes (presumably #146862) made this pull request unmergeable. Please resolve the merge conflicts. |
548489e
to
2985abf
Compare
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #147019) made this pull request unmergeable. Please resolve the merge conflicts. |
2985abf
to
94efefb
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
r? compiler |
94efefb
to
088afec
Compare
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
The job Click to see the possible cause of the failure (guessed by this bot)
|
pub fn foo1(input: TokenStream) -> TokenStream { input } | ||
pub fn foo1(input: TokenStream) -> TokenStream { | ||
input | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you undo the reformatting of this file? Files within tests/ui/
aren't auto-formatted, and it's just churn that obscures the actual change in this commit.
✌️ @jdonszelmann, you can now approve this pull request! If @nnethercote told you to " |
☔ The latest upstream changes (presumably #147345) made this pull request unmergeable. Please resolve the merge conflicts. |
r? estebank
tiny diagnostic fix, mostly we were using the wrong method on the context so I added a new method that is right for the situation