support opaque types in method selection #146885
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
|
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
method-selection-opaques
branch
from
9071886 to
0cf7b6a
Compare
lcnr
commented
Sep 23, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
method-selection-opaques
branch
from
45af29b to
25acecb
Compare
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
method-selection-opaques
branch
from
25acecb to
cb38942
Compare
|
This PR modifies |
rustbot
added
S-waiting-on-review
BoxyUwU
added
the
S-no-work-capacity-tracking
This comment has been minimized.
This comment has been minimized.
lcnr
force-pushed
the
method-selection-opaques
branch
from
cb38942 to
be0f84f
Compare
This comment has been minimized.
This comment has been minimized.
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 23, 2025
support opaque types in method selection
rustbot
added
the
S-waiting-on-perf
lcnr
force-pushed
the
method-selection-opaques
branch
from
be0f84f to
0050715
Compare
lcnr
force-pushed
the
method-selection-opaques
branch
from
508b75d to
8ff5eee
Compare
This comment has been minimized.
This comment has been minimized.
BoxyUwU
reviewed
Sep 26, 2025
`autoderef` already resolved and `method_autoderef_steps` makes sure we won't encounter an inference variable
We'll still error due to the `opt_bad_ty` of `method_autoderef_steps`. This slightly worsens the span of `infer_var.method()` which is now the same as for `Box::new(infer_var).method()`. Unlike `structurally_resolve_type`, `probe_op` does not check whether the infcx is already tainted, so this results in 2 previously not emitted errors.
lcnr
force-pushed
the
method-selection-opaques
branch
from
8ff5eee to
c2e39c2
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors r=BoxyUwU |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing a885811 (parent) -> 54a8a1d (this PR) Test differencesShow 102 test diffsStage 1
Stage 2
Additionally, 42 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 54a8a1db604e4caff93e26e167ad4a6fde9f0681 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (54a8a1d): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -2.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 3.5%, secondary 10.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 470.315s -> 471.437s (0.24%) |
This was referenced Sep 27, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my notes in https://hackmd.io/4ILASx3mQ3u_gW9r1JyqCw.
This PR builds on #145993 and allows not-yet defined opaque types as self types in the
method_autoderef_chain.E.g. for
Box<impl Deref<impl Foo>>this results in the autoderef chainBox<impl Deref> -> ?deref_hidden_ty -> ?foo_hidden_ty. Method selection stays ambiguous if the final autoderef step is still an infer var unless that var is an opaque.TODO: treating opaques as rigid jank.
r? @BoxyUwU