Deduplicated float tests and unified in floats/mod.rs #148206

xonx4l · 2025-10-28T12:23:42Z

In this PR Float tests are deduplicated and are unified in floats/mod.rs, as discussed in #141726.

The moved float tests are:

-> test_powf
-> test_exp
-> test_exp2
-> test_ln
-> test_log_generic
-> test_log2
-> test_log10
-> test_asinh
-> test_acosh
-> test_atanh
-> test_gamma
-> test_ln_gamma

Closes: #141726

r? tgross35

rustbot · 2025-10-28T12:23:47Z

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

library/std/tests/floats/lib.rs

xonx4l · 2025-11-11T12:19:21Z

Any update @bjorn3 ?

bjorn3 · 2025-11-11T12:22:56Z

CI is still failing.

xonx4l · 2025-11-11T12:27:03Z

CI is still failing.

ok let me fix .

rustbot · 2025-11-14T08:23:07Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

LorrensP-2158466 · 2025-11-17T23:39:14Z

library/coretests/tests/floats/mod.rs

+        let inf: Float = Float::INFINITY;
+        let neg_inf: Float = Float::NEG_INFINITY;
+        assert_biteq!((10.0 as Float).log(10.0), 1.0);
+        assert_approx_eq!((2.3 as Float).log(3.5), 0.664858, Float::LOG_APPROX);


This test here for f128 will fail because the precision is much higher, if you look at the original test, the expected value is much more precise than what you have written:

assert_approx_eq!(2.3f128.log(3.5), 0.66485771361478710036766645911922010272, TOL);

When testing higher precision floats, you need much more precise expected values or the tests will fail, as they do now. In Miri, this is even more strict.

If you look at the source of f16 constants, they use much more digits after the decimal point than needed:

pub const PI: f16 = 3.14159265358979323846264338327950288_f16;

So you should probably do that as well.

Okay it makes sense . Thanks

tgross35 · 2025-11-19T14:09:50Z

Thank you for the final cleanup here. Until CI is fixed,
@rustbot author

rustbot · 2025-11-19T14:09:55Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

xonx4l · 2025-11-19T18:27:09Z

Thank you for the final cleanup here. Until CI is fixed, @rustbot author

Will finish this as soon as possible . A bit busy these days.

@ghost

…uwer Rollup of 8 pull requests Successful merges: - #148206 (Deduplicated float tests and unified in floats/mod.rs) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

rust-bors · 2026-01-22T12:23:02Z

⌛ Testing commit 6ac8ff7 with merge e822724...

Workflow: https://github.com/rust-lang/rust/actions/runs/21248296883

Deduplicated float tests and unified in floats/mod.rs In this PR Float tests are deduplicated and are unified in floats/mod.rs, as discussed in #141726. The moved float tests are: -> test_powf -> test_exp -> test_exp2 -> test_ln -> test_log_generic -> test_log2 -> test_log10 -> test_asinh -> test_acosh -> test_atanh -> test_gamma -> test_ln_gamma Closes: #141726

JonathanBrouwer · 2026-01-22T12:27:45Z

@bors yield
Yield to enclosing rollup that failed spuriously

rust-bors · 2026-01-22T12:27:49Z

Auto build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/21248296883

The next pull request likely to be tested is #151485.

@ghost

…uwer Rollup of 8 pull requests Successful merges: - #148206 (Deduplicated float tests and unified in floats/mod.rs) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

JonathanBrouwer · 2026-01-22T12:35:16Z

Actually I think this PR failed that rollup
@bors r-
#151485 (comment)

Not sure, if you disagree start a try job and then r+ again

rust-bors · 2026-01-22T12:35:21Z

Commit 6ac8ff7 has been unapproved.

@ghost

…uwer Rollup of 8 pull requests Successful merges: - #148206 (Deduplicated float tests and unified in floats/mod.rs) - #151042 (fix fallback impl for select_unpredictable intrinsic) - #151220 (option: Use Option::map in Option::cloned) - #151260 (Handle unevaluated ConstKind in in_operand) - #151441 (Fix ICE: Don't try to evaluate type_consts when eagerly collecting items) - #151465 (codegen: clarify some variable names around function calls) - #151469 (llvm: Tolerate dead_on_return attribute changes) - #151476 (Avoid `-> ()` in derived functions.) r? @ghost

tgross35 · 2026-01-23T08:09:29Z

library/coretests/tests/floats/mod.rs

+    name: powf,
+    attrs: {
+        const: #[cfg(false)],
+        f16: #[cfg(any(miri, target_has_reliable_f16_math))],
+        f128: #[cfg(all(not(miri), target_has_reliable_f128_math))],
+    },


Looks like f16 needs to be not(miri), similar to f128

rust/library/std/tests/floats/f16.rs

Line 52 in 1655912

#[cfg(not(miri))]

That applies to most of the new functions here, check them against that source file.

tgross35 · 2026-01-24T05:46:08Z

compiler/rustc_codegen_cranelift/patches/0029-sysroot_tests-disable-f16-math.patch

Seems like this patch file needs to be regenerated against the new changes

Yes, Was doing that but got some work so couldn't send the push but will send one asap .

rustbot · 2026-01-24T07:19:22Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

tgross35 · 2026-01-24T07:30:16Z

@bors try jobs=x86_64-gnu-aux

Deduplicated float tests and unified in floats/mod.rs try-job: x86_64-gnu-aux

rust-bors · 2026-01-24T09:01:17Z

💔 Test for d97b772 failed: CI. Failed job:

try - x86_64-gnu-aux (web logs, enhanced plaintext logs)

tgross35 · 2026-01-26T06:42:47Z

library/coretests/tests/floats/mod.rs

+    test<Float> {
+        let nan: Float = Float::NAN;
+        let inf: Float = Float::INFINITY;
+        let neg_inf: Float = Float::NEG_INFINITY;


Looks like f16 needs to be not(miri), similar to f128

rust/library/std/tests/floats/f16.rs

Line 52 in 1655912

#[cfg(not(miri))]

That applies to most of the new functions here, check them against that source file.

For some reason this comment got added to the wrong line, but it's referring to the current config:

f16: #[cfg(any(not(miri), target_has_reliable_f16_math))], f128: #[cfg(all(not(miri), target_has_reliable_f128_math))],

Changed all f16 from this -> f16: #[cfg(any(not(miri), target_has_reliable_f16_math))] to this -> f16: #[cfg(all(not(miri), target_has_reliable_f16_math))].

I think for this change a new patch generation won't be required . But let's wait for ci.

Oh looks like I will need to regenerate the patch again.

rustbot assigned tgross35 Oct 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 28, 2025