Remove unused code in cfg_old
#149903
Open
Remove unused code in cfg_old
#149903
+25
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
11 tasks
Contributor
|
this is awesome work! thanks :) Finally getting rid of some old attr code @bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 12, 2025
…=jdonszelmann Remove unused code in `cfg_old` r? `@jdonszelmann` Fixes one of the todos from rust-lang#149865
Member
bors
added
S-waiting-on-author
Member
|
@bors try job=aarch64-gnu-llvm-20-2 |
|
Unknown argument "job". Run |
Member
|
@bors2 try jobs=aarch64-gnu-llvm-20-2 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 12, 2025
Remove unused code in `cfg_old` try-job: aarch64-gnu-llvm-20-2
This comment has been minimized.
This comment has been minimized.
|
💔 Test for ea469cb failed: CI. Failed jobs:
|
Contributor
Author
|
@bors2 try jobs=aarch64-gnu-llvm-20-2 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Dec 12, 2025
Remove unused code in `cfg_old` try-job: aarch64-gnu-llvm-20-2
Contributor
Author
|
Why did PR ci not catch that failure btw? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 44d7933 failed: CI. Failed jobs:
|
JonathanBrouwer
force-pushed
the
cfg_old_cleanup
branch
from
322e0f7 to
0ab4b8b
Compare
Contributor
Author
|
@bors2 try jobs=aarch64-gnu-llvm-20-2 |
rust-bors bot
added a commit
that referenced
this pull request
Dec 12, 2025
Remove unused code in `cfg_old` try-job: aarch64-gnu-llvm-20-2
This comment has been minimized.
This comment has been minimized.
Contributor
|
r=me on ci pass |
Contributor
Author
|
@bors r=jdonszelmann rollup |
Collaborator
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Dec 12, 2025
…=jdonszelmann Remove unused code in `cfg_old` r? `@jdonszelmann` Fixes one of the todos from rust-lang#149865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @jdonszelmann
Fixes one of the todos from #149865