Skip to content

try enabling linker-messages by default again #149937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jyn514 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

try enabling linker-messages by default again #149937

jyn514 wants to merge 4 commits into from
+306 −54

Conversation

@jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 13, 2025 •
edited
Loading

  • Split out linker-info from linker-messages
  • Make linker-messages warn-by-default; keep linker-info deny-by-default

Helps with #136096.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@saethlin
Copy link
Member

saethlin commented Dec 13, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 13, 2025
@rust-bors
Auto merge of #149937 - jyn514:linker-info, r=<try>
58b1b3c 
try enabling `linker-messages` by default again
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Dec 13, 2025

☀️ Try build successful (CI)
Build commit: 58b1b3c (58b1b3c5342a414c161338871f8004258ccef2a7, parent: eb171a227f9e5de5d376b6edb56b174bc8235fb3)

@saethlin
Copy link
Member

saethlin commented Dec 13, 2025

@craterbot build-only

@craterbot
Copy link
Collaborator

craterbot commented Dec 13, 2025

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@saethlin
Copy link
Member

saethlin commented Dec 13, 2025

@craterbot run mode=build-only

@craterbot
Copy link
Collaborator

craterbot commented Dec 13, 2025

👌 Experiment pr-149937 created and queued.
🤖 Automatically detected try build 58b1b3c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2025
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Dec 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 mentioned this pull request Dec 14, 2025
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#149969 - jyn514:ibt, r=jieyouxu
efdd61d 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang#149937.

cc `@jieyouxu` `@Oneirical`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#149969 - jyn514:ibt, r=jieyouxu
1b7cc44 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang#149937.

cc ``@jieyouxu`` ``@Oneirical``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#149969 - jyn514:ibt, r=jieyouxu
98f8736 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang#149937.

cc ```@jieyouxu``` ```@Oneirical```
rust-timer added a commit that referenced this pull request Dec 15, 2025
@rust-timer
Unrolled build for #149969
d399792 
Rollup merge of #149969 - jyn514:ibt, r=jieyouxu

don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of #149937.

cc ```@jieyouxu``` ```@Oneirical```
@bors
Copy link
Collaborator

bors commented Dec 15, 2025

☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Dec 18, 2025
@matthiaskrgr
Rollup merge of #149969 - jyn514:ibt, r=jieyouxu
a0921cf 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang/rust#149937.

cc ```@jieyouxu``` ```@Oneirical```
@craterbot
Copy link
Collaborator

craterbot commented Dec 25, 2025

🚧 Experiment pr-149937 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Dec 27, 2025

🎉 Experiment pr-149937 is completed!
📊 24 regressed and 5 fixed (758860 total)
📊 2582 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149937/retry-regressed-list.txt ↩

mati865
mati865 reviewed Feb 4, 2026
View reviewed changes
Copy link
Member

@mati865 mati865 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of questions regarding the tests, to make sure they don't cause issues for people working on their machines.

View changes since this review

compiler/rustc_codegen_ssa/src/back/link.rs
Comment on lines +687 to +693
fn is_windows_gnu_ld(sess: &Session) -> bool {
let (_, flavor) = linker_and_flavor(sess);
sess.target.is_like_windows
&& !sess.target.is_like_msvc
&& matches!(flavor, LinkerFlavor::Gnu(_, Lld::No))
}
Copy link
Member

@mati865 mati865 Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will match windows-gnu and windows-gnullvm targets. Probably doesn't matter enough to justify adding && sess.target.abi != Abi::Llvm there.

@mati865
Copy link
Member

mati865 commented Feb 4, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2026
@jyn514
Copy link
Member Author

jyn514 commented Feb 4, 2026

@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 4, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 4, 2026

✌️ @jyn514, you can now approve this pull request!

If @mati865 told you to "r=me" after making some further change, then please make that change and post @bors r=mati865.

@jyn514
Copy link
Member Author

jyn514 commented Feb 4, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2026
@rustbot

This comment has been minimized.

Sign in to view
@jyn514
Copy link
Member Author

jyn514 commented Feb 6, 2026

@bors try jobs=x86_64-mingw-1,x86_64-mingw-2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Feb 6, 2026
@bors
Auto merge of #149937 - jyn514:linker-info, r=<try>
02e4e25 
try enabling `linker-messages` by default again


try-job: x86_64-mingw-1
try-job: x86_64-mingw-2
@rustbot rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 6, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 6, 2026

💔 Test for 02e4e25 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@mati865
Copy link
Member

mati865 commented Feb 6, 2026

error: ui test did not emit an error

😌

@rust-bors

This comment has been minimized.

Sign in to view
@mati865
Copy link
Member

mati865 commented Feb 7, 2026

I think Use a fake linker so tests are platform-independent commit should be squashed into the commit that adds the test, so we don't have a commit that surely fails the tests.
I'll give it another review pass in a few days, when flu no longer blocks my reasoning.

jyn514 and others added 4 commits February 7, 2026 22:37
@jyn514
Split is_msvc_link_exe into a function
ffa3878
@jyn514
Split report_linker_output into its own function
4a192c8
@jyn514
Split out linker-info from linker-messages
0bea000 
- Hide common linker output behind `linker-info`
- Add tests
- Account for different capitalization on windows-gnu when removing
  "warning" prefix
- Add some more comments
- Add macOS deployment-target test
- Ignore linker warnings from trying to statically link glibc

  I don't know what's going on in `nofile-limit.rs` but I want no part
  of it.

- Use a fake linker so tests are platform-independent
@jyn514
Set linker-messages to warn-by-default
8ee8d40
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mati865 mati865 mati865 left review comments

Assignees

@mati865 mati865

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-run-make Area: port run-make Makefiles to rmake.rs A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jyn514 @rust-log-analyzer @saethlin @craterbot @bors @mati865 @rustbot @zacknewman @BoxyUwU