-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Write file with channel to S3 #149964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Write file with channel to S3 #149964
Conversation
|
The goal is to replace the code here: https://github.com/kennytm/rustup-toolchain-install-master/blob/5dc0ab4060685445311ac7224d12cd60bd6df175/src/main.rs#L370 with a single fetch of the appropriate artifact. @bors try |
This comment has been minimized.
This comment has been minimized.
Write file with channel to S3
This comment has been minimized.
This comment has been minimized.
|
💔 Test for cf1d71c failed: CI. Failed jobs:
|
a8e9bc2 to
abadc70
Compare
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Write file with channel to S3
|
r? @marcoieni rustbot has assigned @marcoieni. Use |
abadc70 to
e1e7791
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
Write file with channel to S3
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
Write file with channel to S3
238a8a0 to
e1e7791
Compare
|
Try jobs:
Presuming those produce expected artifacts should be ready for review. |
|
💔 Test for d9d71ef failed: CI. Failed jobs:
|
This comment has been minimized.
This comment has been minimized.
This will let rustup-toolchain-install-master gain support for installing stable artifacts, which is currently only possible when explicitly overriding the channel. That in turn will unblock letting Crater kick off a beta run as soon as both a new beta and a new stable artifact are ready, rather than waiting until the actual release.
e1e7791 to
bdc8894
Compare
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Write file with channel to S3
This comment has been minimized.
This comment has been minimized.
e76556c to
bdc8894
Compare
|
https://ci-artifacts.rust-lang.org/rustc-builds/2a59135288568ce16db9c4f25263a2c29c8cce11/package-version looks good! You can r=me. |
This will let rustup-toolchain-install-master gain support for installing stable artifacts, which is currently only possible when explicitly overriding the channel. That in turn will unblock letting Crater kick off a beta run as soon as both a new beta and a new stable artifact are ready, rather than waiting until the actual release.