Skip to content

Conversation

@Mark-Simulacrum
Copy link
Member

This will let rustup-toolchain-install-master gain support for installing stable artifacts, which is currently only possible when explicitly overriding the channel. That in turn will unblock letting Crater kick off a beta run as soon as both a new beta and a new stable artifact are ready, rather than waiting until the actual release.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 13, 2025
@Mark-Simulacrum
Copy link
Member Author

The goal is to replace the code here: https://github.com/kennytm/rustup-toolchain-install-master/blob/5dc0ab4060685445311ac7224d12cd60bd6df175/src/main.rs#L370 with a single fetch of the appropriate artifact.

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 13, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Dec 14, 2025

💔 Test for cf1d71c failed: CI. Failed jobs:

@Mark-Simulacrum
Copy link
Member Author

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 20, 2025
@rust-bors
Copy link

rust-bors bot commented Dec 20, 2025

☀️ Try build successful (CI)
Build commit: bcde5a8 (bcde5a8325a0846881ff81f5aeb7b2493caa8e77, parent: b53da9908134f77da3bb36e7009ac81f02ee48dc)

@Mark-Simulacrum Mark-Simulacrum marked this pull request as ready for review December 20, 2025 23:25
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 20, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 20, 2025

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Mark-Simulacrum Mark-Simulacrum marked this pull request as draft December 21, 2025 18:24
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2025
@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Dec 21, 2025
@Mark-Simulacrum

This comment was marked as resolved.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 21, 2025
@Mark-Simulacrum

This comment was marked as resolved.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 21, 2025
@Mark-Simulacrum
Copy link
Member Author

Try jobs:

Presuming those produce expected artifacts should be ready for review.

@rust-bors
Copy link

rust-bors bot commented Dec 21, 2025

💔 Test for d9d71ef failed: CI. Failed jobs:

@rust-log-analyzer

This comment has been minimized.

This will let rustup-toolchain-install-master gain support for
installing stable artifacts, which is currently only possible when
explicitly overriding the channel. That in turn will unblock letting
Crater kick off a beta run as soon as both a new beta and a new stable
artifact are ready, rather than waiting until the actual release.
@Mark-Simulacrum
Copy link
Member Author

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Dec 22, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Dec 22, 2025

☀️ Try build successful (CI)
Build commit: 2a59135 (2a59135288568ce16db9c4f25263a2c29c8cce11, parent: a6525d5264da34f51ad48c178281d3c6323dbfcf)

@Kobzol
Copy link
Member

Kobzol commented Dec 22, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants