-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
Add dist step for Enzyme #150071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add dist step for Enzyme #150071
Conversation
|
@bors try |
Add dist step for Enzyme try-job: dist-x86_64-linux
This comment has been minimized.
This comment has been minimized.
|
💥 Test timed out after |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Add dist step for Enzyme try-job: dist-x86_64-linux
This comment has been minimized.
This comment has been minimized.
|
💔 Test for bf1f04d failed: CI. Failed jobs:
|
|
☔ The latest upstream changes (presumably #150079) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Add dist step for Enzyme try-job: dist-x86_64-linux
| builder.compiler(target_compiler.stage - 1, builder.config.host_target); | ||
|
|
||
| // Build enzyme | ||
| if builder.config.llvm_enzyme && !builder.config.dry_run() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore if it's just for testing, but the dry_run check was needed as bugfix for something, might have been check builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I don't understand why something is in bootstrap, I usually remove it, then wait if something breaks, and if it does, I readd it back with a comment, so that we know why it is there :)
Now that Enzyme can be distributed as a separate dylib outside libLLVM.so, we can create a dist step for it. This is the bulk of the work required to make it distributable through rustup, once CI works and we check that the built component works locally, we can add it to Rustup through the manifest.
r? @ZuseZ4
try-job: dist-x86_64-linux