Skip to content

Conversation

@louwenus
Copy link

@louwenus louwenus commented Dec 17, 2025

Dirty fix to #145069
While waiting for a proper fix, at least document what is happening in the error so that the next to stumble on the issue hopefully does not waste too much time debugging it.

Dirty fix to rust-lang#145069
While waiting for a proper fix, at least document what is happening in the error so that the next to stumble on the issue hopefully does not waste too much time debugging it.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 17, 2025
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Dec 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2025

r? @madsmtm

rustbot has assigned @madsmtm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Dec 17, 2025

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@rust-log-analyzer

This comment has been minimized.

Shorter lines
@rust-log-analyzer

This comment has been minimized.

Fixed typo
@louwenus louwenus changed the title Update E0275.md E0275: Point a additional error case while waiting for a proper fix Dec 17, 2025
@louwenus
Copy link
Author

⚠️ Warning ⚠️

* There are issue links (such as `#123`) in the commit messages of the following commits.
  _Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree._
  
  * [9c55d56](https://github.com/rust-lang/rust/commit/9c55d5676bcb74b23934b7b4f3147cab4083a889)

Well it is in the PR description too, and I do not know how to edit commit message.
If it is important, could someone tell me how to do it ? Thanks

@madsmtm
Copy link
Contributor

madsmtm commented Dec 21, 2025

Hmm, I'm kinda of two minds about this. On one hand, I'm in favour of more docs, but on the other hand, generic_const_exprs is marked incomplete, so I don't really want to start calling out in docs everywhere that it doesn't work (especially because such documentation will easily get outdated).

Arguably, the problem is perhaps more that you're able to have a dependency that uses an incomplete feature like generic_const_exprs, and not get a warning about it when compiling the root crate?

I do not know how to edit commit message

There's many ways to do it, one option is to use git rebase, another is something like git commit --amend, I can recommend Chapter 7.6 in the Git Book. After that, you'll need to use a force push, something like git push --force-with-lease.

Feel free to ask questions about it, but perhaps let's discuss if this is something that we want to do first ;)

@madsmtm madsmtm added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants