MGCA: Support literals as direct const arguments #150699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

rust-bors merged 1 commit into rust-lang:main from Human9000-bit:literals-as-direct-const-args

Jan 9, 2026

+47 −17

Contributor

Human9000-bit commented Jan 5, 2026

initial changes for mcga literals
rustfmt

rustbot assigned BoxyUwU

rustbot added S-waiting-on-author T-clippy T-compiler T-rustdoc labels

Collaborator

rustbot commented Jan 5, 2026

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

Contributor Author

Human9000-bit commented Jan 5, 2026 •

edited

Loading

rn this is very basic changes, lots of todo!() s
took me some time to figure out what to do

This comment has been minimized.

Sign in to view

BoxyUwU reviewed

View reviewed changes

Member

BoxyUwU left a comment •

edited by rustbot

Loading

This is looking good already! You've touched pretty much everywhere that will be necessary for this change so it's only filling out these todo!s now :)

View changes since this review

compiler/rustc_hir/src/hir.rs Outdated Show resolved Hide resolved

compiler/rustc_ast_lowering/src/lib.rs Outdated Show resolved Hide resolved

compiler/rustc_hir/src/intravisit.rs Outdated

    
                      ConstArgKind::Path(qpath) => visitor.visit_qpath(qpath, *hir_id, qpath.span()),

                      ConstArgKind::Anon(anon) => visitor.visit_anon_const(*anon),

                      ConstArgKind::Error(_, _) => V::Result::output(), // errors and spans are not important

                      ConstArgKind::Literal(_, _) => todo!(),

Member

BoxyUwU Jan 5, 2026

In theory we should be calling visitor.visit_lit here. I don't think we actually can right now though as lots of implementers of Visitor expect that visit_lit is only called on literals inside of function bodies.

For now I think you can return the default result with V::Result::output() and leave a // FIXME(mgca) to handle const arg literals in HIR visitors at some point

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Show resolved Hide resolved

compiler/rustc_hir_pretty/src/lib.rs Outdated Show resolved Hide resolved

src/librustdoc/clean/mod.rs Outdated Show resolved Hide resolved

src/librustdoc/clean/mod.rs Outdated Show resolved Hide resolved

BoxyUwU mentioned this pull request

Tracking Issue for Generic Constant Arguments MVP #132980

Open

29 tasks

Human9000-bit marked this pull request as ready for review

January 6, 2026 11:35

rustbot added the S-waiting-on-review label

Collaborator

rustbot commented Jan 6, 2026

HIR ty lowering was modified

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

rustbot removed the S-waiting-on-author label

This comment has been minimized.

Sign in to view

rustbot added the has-merge-commits label

Contributor Author

Human9000-bit commented Jan 6, 2026

too bad I have made a merge commit

This comment has been minimized.

Sign in to view

Human9000-bit force-pushed the literals-as-direct-const-args branch from acd1271 to 78149e6 Compare

January 6, 2026 12:31

This comment has been minimized.

Sign in to view

rustbot removed the has-merge-commits label

Human9000-bit marked this pull request as draft

January 6, 2026 12:31

rustbot added S-waiting-on-author and removed S-waiting-on-review labels

Human9000-bit force-pushed the literals-as-direct-const-args branch 2 times, most recently from d60c5dd to 37f084a Compare

January 6, 2026 13:05

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

BoxyUwU reviewed

View reviewed changes

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Outdated Show resolved Hide resolved

Human9000-bit force-pushed the literals-as-direct-const-args branch from 28fc1a0 to fafe96e Compare

January 8, 2026 15:21

This comment has been minimized.

Sign in to view

Human9000-bit force-pushed the literals-as-direct-const-args branch from fafe96e to 1d10a8f Compare

January 8, 2026 15:25

Collaborator

rustbot commented Jan 8, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Contributor Author

Human9000-bit commented Jan 8, 2026

@BoxyUwU we are ready to merge


          MGCA: literals support

9f3956f

Contributor Author

Human9000-bit commented Jan 8, 2026 •

edited

Loading

😅 I've noticed i named it MCGA instead of MGCA

Human9000-bit force-pushed the literals-as-direct-const-args branch from 1d10a8f to 9f3956f Compare

January 8, 2026 15:29

camelid reviewed

View reviewed changes

compiler/rustc_hir/src/intravisit.rs Show resolved Hide resolved

Member

BoxyUwU commented Jan 8, 2026

@bors r+ rollup

there's definitely follow up work here:

negated literals (important for isize const generics)
lit_to_const is very ICEy on wrong types and we should have proper diagnostics

so if you're interested in doing more work here that'd be very cool :)

rust-bors bot added S-waiting-on-bors and removed S-waiting-on-review labels

Contributor

rust-bors bot commented Jan 8, 2026

📌 Commit 9f3956f has been approved by BoxyUwU

It is now in the queue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#150699 - literals-as-direct-const-args, r=B…

bab3c6a

…oxyUwU

MGCA: Support literals as direct const arguments

Fixes [rust-lang#150168](rust-lang#150618)

- **initial changes for mcga literals**
- **rustfmt**

r? @BoxyUwU

matthiaskrgr mentioned this pull request

Rollup of 12 pull requests #150830

Closed

rust-bors bot added a commit that referenced this pull request


          Auto merge of #150830 - matthiaskrgr:rollup-x97BiJe, r=matthiaskrgr

c6f0428

Rollup of 12 pull requests

Successful merges:

 - #149961 (tidy: add if-installed prefix condition to extra checks system)
 - #150475 (std: sys: fs: uefi: Implement initial File)
 - #150533 (std: sys: fs: uefi: Implement remove_dir_all)
 - #150549 (fix missing_panics_doc in `std::os::fd::owned`)
 - #150699 (MGCA: Support literals as direct const arguments)
 - #150721 (Deprecated doc intra link)
 - #150752 (Update libc to v0.2.180)
 - #150802 (Minor cleanups to fn_abi_new_uncached)
 - #150803 (compiler-builtins subtree update)
 - #150809 (Update `literal-escaper` version to `0.0.7`)
 - #150811 (Store defids instead of symbol names in the aliases list)
 - #150825 (Query associated_item_def_ids when needed)

r? @ghost

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#150699 - literals-as-direct-const-args, r=B…

5a3e316

…oxyUwU

MGCA: Support literals as direct const arguments

Fixes [rust-lang#150168](rust-lang#150618)

- **initial changes for mcga literals**
- **rustfmt**

r? @BoxyUwU

matthiaskrgr mentioned this pull request

Rollup of 11 pull requests #150832

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#150699 - literals-as-direct-const-args, r=B…

1a5ba32

…oxyUwU

MGCA: Support literals as direct const arguments

Fixes [rust-lang#150168](rust-lang#150618)

- **initial changes for mcga literals**
- **rustfmt**

r? @BoxyUwU

matthiaskrgr mentioned this pull request

Rollup of 10 pull requests #150837

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#150699 - literals-as-direct-const-args, r=B…

2b8d954

…oxyUwU

MGCA: Support literals as direct const arguments

Fixes [rust-lang#150168](rust-lang#150618)

- **initial changes for mcga literals**
- **rustfmt**

r? @BoxyUwU

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#150699 - literals-as-direct-const-args, r=B…

eb4256d

…oxyUwU

MGCA: Support literals as direct const arguments

Fixes [rust-lang#150168](rust-lang#150618)

- **initial changes for mcga literals**
- **rustfmt**

r? @BoxyUwU

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#150699 - literals-as-direct-const-args, r=B…

a74c2fb

…oxyUwU

MGCA: Support literals as direct const arguments

Fixes [rust-lang#150168](rust-lang#150618)

- **initial changes for mcga literals**
- **rustfmt**

r? @BoxyUwU

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#150699 - literals-as-direct-const-args, r=B…

ab5075d

…oxyUwU

MGCA: Support literals as direct const arguments

Fixes [rust-lang#150168](rust-lang#150618)

- **initial changes for mcga literals**
- **rustfmt**

r? @BoxyUwU

This was referenced Jan 8, 2026

Rollup of 12 pull requests #150838

Closed

Rollup of 11 pull requests #150839

Merged

rust-bors bot added a commit that referenced this pull request


          Auto merge of #150839 - matthiaskrgr:rollup-3a0ebXJ, r=matthiaskrgr

3fda0e4

Rollup of 11 pull requests

Successful merges:

 - #149961 (tidy: add if-installed prefix condition to extra checks system)
 - #150475 (std: sys: fs: uefi: Implement initial File)
 - #150533 (std: sys: fs: uefi: Implement remove_dir_all)
 - #150549 (fix missing_panics_doc in `std::os::fd::owned`)
 - #150699 (MGCA: Support literals as direct const arguments)
 - #150721 (Deprecated doc intra link)
 - #150802 (Minor cleanups to fn_abi_new_uncached)
 - #150803 (compiler-builtins subtree update)
 - #150809 (Update `literal-escaper` version to `0.0.7`)
 - #150811 (Store defids instead of symbol names in the aliases list)
 - #150825 (Query associated_item_def_ids when needed)

r? @ghost

rust-bors bot merged commit cb3b2d8 into rust-lang:main

11 checks passed

rustbot added this to the 1.94.0 milestone

rust-timer added a commit that referenced this pull request


          Unrolled build for #150699

7dcb568

Rollup merge of #150699 - literals-as-direct-const-args, r=BoxyUwU

MGCA: Support literals as direct const arguments

Fixes [#150168](#150618)

- **initial changes for mcga literals**
- **rustfmt**

r? @BoxyUwU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors T-clippy T-compiler T-rustdoc