Skip to content

Rollup of 3 pull requests #150700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 7 commits into from
Jan 5, 2026
Merged

Rollup of 3 pull requests #150700

bors merged 7 commits into from
Jan 5, 2026

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jan 5, 2026 •
edited by rustbot
Loading

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

JonathanBrouwer and others added 7 commits December 22, 2025 16:26
@JonathanBrouwer
Make attr path symbols rather than idents
7afba29
@reddevilmidzy
moved some test
5c5c1ff 
delete tests/ui/issues/issue-22426.rs duplicated of tests/ui/match/guards.rs
@reddevilmidzy
cleaned up some tests
93f8ad9 
cleaned up cast-enum-const.rs

cleaned up ufcs-trait-object-format.rs

add comment to cast-to-box-arr.rs

add comment to shadow-primitives.rs

add comment to associated-type-const-nomalization.rs

add comment to fn-trait-explicit-call.rs

add comment to call-unit-struct-impl-fn-once.rs

add comment to cast-to-char-compare.rs

add comment to self-in-method-body-resolves.rs

add comment to derive-debug-newtype-unsized-slice.rs

add comment to tuple-ref-order-distinct-impls.rs

add comment to derive-debug-generic-with-lifetime.rs

add comment to recursive-trait-bound-on-type-param.rs

cleaned up const-static-ref-to-closure.rs

add comment to const-iter-no-conflict-for-loop.rs
@hkBst
relate.rs: tiny cleanup: eliminate temp vars 2
3d6a2c5
@Kobzol
Rollup merge of rust-lang#149790 - JonathanBrouwer:attr-path-perf, r=…
b198dff 
…jdonszelmann

Remove `Span` from segments of `AttrPath`

r? jdonszelmann
@Kobzol
Rollup merge of rust-lang#150384 - reddevilmidzy:t14, r=Kivooeo
5bcdc7c 
Tidying up tests/ui/issues 16 tests [7/N]

> [!NOTE]
> Intermediate commits are intended to help review, but will be squashed add comment commit prior to merge.

part of rust-lang#133895

r? Kivooeo
@Kobzol
Rollup merge of rust-lang#150697 - hkBst:relate-3, r=Kivooeo
469a264 
relate.rs: tiny cleanup: eliminate temp vars 2

Continuation of rust-lang#150678

r? `@Kivooeo`
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 5, 2026
@Kobzol
Copy link
Member Author

Kobzol commented Jan 5, 2026

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Jan 5, 2026

📌 Commit 469a264 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2026
@bors
Copy link
Collaborator

bors commented Jan 5, 2026

⌛ Testing commit 469a264 with merge 4fa80a5...

@bors
Copy link
Collaborator

bors commented Jan 5, 2026

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 4fa80a5 to main...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 5, 2026
@bors bors merged commit 4fa80a5 into rust-lang:main Jan 5, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 5, 2026
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 5, 2026

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#149790 Remove Span from segments of AttrPath 7bda2dc968a9ad7d159cb10e36a708132f2dfabe (link)
#150384 Tidying up tests/ui/issues 16 tests [7/N] 868d66c92d32edfbe1cd32ee29919e6ba7ce4bcc (link)
#150697 relate.rs: tiny cleanup: eliminate temp vars 2 262cf0af9f0b0277f16d950ba844c749ced20f68 (link)

previous master: bd33b83cfd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing bd33b83 (parent) -> 4fa80a5 (this PR)

Test differences

Show 81 test diffs

Stage 1

  • [ui] tests/ui/associated-types/associated-type-const-nomalization.rs: [missing] -> pass (J1)
  • [ui] tests/ui/cast/cast-enum-const.rs: [missing] -> pass (J1)
  • [ui] tests/ui/cast/cast-to-box-arr.rs: [missing] -> pass (J1)
  • [ui] tests/ui/cast/cast-to-char-compare.rs: [missing] -> pass (J1)
  • [ui] tests/ui/consts/const-static-ref-to-closure.rs: [missing] -> pass (J1)
  • [ui] tests/ui/derives/derive-debug-generic-with-lifetime.rs: [missing] -> pass (J1)
  • [ui] tests/ui/derives/derive-debug-newtype-unsized-slice.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn_traits/call-unit-struct-impl-fn-once.rs: [missing] -> pass (J1)
  • [ui] tests/ui/fn_traits/fn-trait-explicit-call.rs: [missing] -> pass (J1)
  • [ui] tests/ui/issues/issue-11384.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-19601.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-20427.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-20676.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-20847.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-22403.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-22426.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-2428.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-24389.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-25180.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-25394.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-26614.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-27639.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-29030.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-33687.rs: pass -> [missing] (J1)
  • [ui] tests/ui/issues/issue-41998.rs: pass -> [missing] (J1)
  • [ui] tests/ui/resolve/const-iter-no-conflict-for-loop.rs: [missing] -> pass (J1)
  • [ui] tests/ui/resolve/shadow-primitives.rs: [missing] -> pass (J1)
  • [ui] tests/ui/self/self-in-method-body-resolves.rs: [missing] -> pass (J1)
  • [ui] tests/ui/traits/bound/recursive-trait-bound-on-type-param.rs: [missing] -> pass (J1)
  • [ui] tests/ui/typeck/tuple-ref-order-distinct-impls.rs: [missing] -> pass (J1)
  • [ui] tests/ui/ufcs/ufcs-trait-object-format.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/associated-types/associated-type-const-nomalization.rs: [missing] -> pass (J0)
  • [ui] tests/ui/cast/cast-enum-const.rs: [missing] -> pass (J0)
  • [ui] tests/ui/cast/cast-to-box-arr.rs: [missing] -> pass (J0)
  • [ui] tests/ui/cast/cast-to-char-compare.rs: [missing] -> pass (J0)
  • [ui] tests/ui/consts/const-static-ref-to-closure.rs: [missing] -> pass (J0)
  • [ui] tests/ui/derives/derive-debug-generic-with-lifetime.rs: [missing] -> pass (J0)
  • [ui] tests/ui/derives/derive-debug-newtype-unsized-slice.rs: [missing] -> pass (J0)
  • [ui] tests/ui/fn_traits/call-unit-struct-impl-fn-once.rs: [missing] -> pass (J0)
  • [ui] tests/ui/fn_traits/fn-trait-explicit-call.rs: [missing] -> pass (J0)
  • [ui] tests/ui/issues/issue-11384.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-19601.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-20427.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-20676.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-20847.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-22403.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-22426.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-2428.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-24389.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-25180.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-25394.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-26614.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-27639.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-29030.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-33687.rs: pass -> [missing] (J0)
  • [ui] tests/ui/issues/issue-41998.rs: pass -> [missing] (J0)
  • [ui] tests/ui/resolve/const-iter-no-conflict-for-loop.rs: [missing] -> pass (J0)
  • [ui] tests/ui/resolve/shadow-primitives.rs: [missing] -> pass (J0)
  • [ui] tests/ui/self/self-in-method-body-resolves.rs: [missing] -> pass (J0)
  • [ui] tests/ui/traits/bound/recursive-trait-bound-on-type-param.rs: [missing] -> pass (J0)
  • [ui] tests/ui/typeck/tuple-ref-order-distinct-impls.rs: [missing] -> pass (J0)
  • [ui] tests/ui/ufcs/ufcs-trait-object-format.rs: [missing] -> pass (J0)

Additionally, 19 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4fa80a5e733e2202d7ca4c203c2fdfda41cfe7dc --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3580.3s -> 4625.0s (+29.2%)
  2. i686-gnu-nopt-1: 7432.7s -> 8600.9s (+15.7%)
  3. aarch64-gnu-llvm-20-1: 3208.4s -> 3639.1s (+13.4%)
  4. i686-gnu-2: 5345.8s -> 6062.7s (+13.4%)
  5. x86_64-gnu-gcc: 3320.2s -> 3753.5s (+13.0%)
  6. x86_64-gnu-tools: 3259.2s -> 3660.9s (+12.3%)
  7. x86_64-gnu-debug: 6774.5s -> 7599.1s (+12.2%)
  8. x86_64-gnu-miri: 4494.8s -> 5032.5s (+12.0%)
  9. i686-gnu-1: 7483.9s -> 8374.0s (+11.9%)
  10. x86_64-rust-for-linux: 2766.6s -> 3093.6s (+11.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bors bors mentioned this pull request Jan 5, 2026
Merged
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 5, 2026

Finished benchmarking commit (4fa80a5): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.0% [0.0%, 0.1%] 2
Improvements ✅
(primary)		 -0.1% [-0.1%, -0.1%] 1
Improvements ✅
(secondary)		 -0.4% [-0.8%, -0.0%] 4
All ❌✅ (primary) -0.1% [-0.1%, -0.1%] 1

Max RSS (memory usage)

Results (primary 2.1%, secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.1% [1.6%, 2.4%] 4
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.9% [-1.9%, -1.9%] 1
All ❌✅ (primary) 2.1% [1.6%, 2.4%] 4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.0% [-0.0%, -0.0%] 8
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.0% [-0.0%, -0.0%] 8

Bootstrap: 473.344s -> 472.645s (-0.15%)
Artifact size: 390.72 MiB -> 390.76 MiB (0.01%)

@rustbot rustbot added the perf-regression Performance regression. label Jan 5, 2026
@Kobzol Kobzol deleted the rollup-02y1lh9 branch January 6, 2026 07:34
@Kobzol
Copy link
Member Author

Kobzol commented Jan 6, 2026

Noise.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

7 participants

@Kobzol @bors @rust-timer @rustbot @JonathanBrouwer @reddevilmidzy @hkBst