Skip to content

Conversation

@orlp
Copy link
Contributor

@orlp orlp commented Jan 6, 2026

Implementation for #150733.

I marked this function as #[must_use] even though the other AtomicPtr constructors aren't. It's unclear to me why they aren't already marked as such, I opened a zulip thread asking about it: #t-libs > Is there a reason AtomicPtr constructors aren't #[must_use]?.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 6, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 6, 2026

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@joboet
Copy link
Member

joboet commented Jan 7, 2026

@bors r+ rollup

@joboet joboet assigned joboet and unassigned scottmcm Jan 7, 2026
@bors
Copy link
Collaborator

bors commented Jan 7, 2026

📌 Commit fff9c62 has been approved by joboet

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 7, 2026
@bors
Copy link
Collaborator

bors commented Jan 7, 2026

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

📌 Commit fff9c62 has been approved by joboet

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 7, 2026
Kobzol added a commit to Kobzol/rust that referenced this pull request Jan 7, 2026
Add AtomicPtr::null

fixes rust-lang#98342
r? @GuillaumeGomez

Renders intra-doc links in the note text of the `#[deprecated]` attribute. It is quite natural to suggest some other function to use there. So e.g.

```rust
#[deprecated(since = "0.0.0", note = "use [`std::mem::size_of`] instead")]
```

renders as

<img width="431" height="74" alt="Screenshot from 2026-01-06 12-08-21" src="https://github.com/user-attachments/assets/8f608f08-13ee-4bbf-a631-6008058a51e2" />
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2026
Add AtomicPtr::null

Implementation for rust-lang#150733.

I marked this function as `#[must_use]` even though the other `AtomicPtr` constructors aren't. It's unclear to me why they aren't already marked as such, I opened a zulip thread asking about it: [#t-libs > Is there a reason AtomicPtr constructors aren't #&rust-lang#91;must_use&rust-lang#93;?](https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/Is.20there.20a.20reason.20AtomicPtr.20constructors.20aren't.20.23.5Bmust_use.5D.3F/with/566624261).
rust-bors bot added a commit that referenced this pull request Jan 8, 2026
Rollup of 11 pull requests

Successful merges:

 - #149976 (Add waker_fn and local_waker_fn to std::task)
 - #150074 (Update provider API docs)
 - #150094 (`c_variadic`: provide our own `va_arg` implementation for more targets)
 - #150164 (rustc: Fix `-Zexport-executable-symbols` on wasm)
 - #150569 (Ensure that static initializers are acyclic for NVPTX)
 - #150607 (Add amdgpu_dispatch_ptr intrinsic)
 - #150694 (./x check miri: enable check_only feature)
 - #150717 (Thread `--jobs` from `bootstrap` -> `compiletest` -> `run-make-support`)
 - #150736 (Add AtomicPtr::null)
 - #150787 (Add myself as co-maintainer for s390x-unknown-linux-musl)
 - #150789 (Fix copy-n-paste error in `vtable_for` docs)

r? @ghost
rust-bors bot added a commit that referenced this pull request Jan 8, 2026
Rollup of 10 pull requests

Successful merges:

 - #149976 (Add waker_fn and local_waker_fn to std::task)
 - #150074 (Update provider API docs)
 - #150094 (`c_variadic`: provide our own `va_arg` implementation for more targets)
 - #150164 (rustc: Fix `-Zexport-executable-symbols` on wasm)
 - #150569 (Ensure that static initializers are acyclic for NVPTX)
 - #150694 (./x check miri: enable check_only feature)
 - #150717 (Thread `--jobs` from `bootstrap` -> `compiletest` -> `run-make-support`)
 - #150736 (Add AtomicPtr::null)
 - #150787 (Add myself as co-maintainer for s390x-unknown-linux-musl)
 - #150789 (Fix copy-n-paste error in `vtable_for` docs)

r? @ghost
@rust-bors rust-bors bot merged commit eaff061 into rust-lang:main Jan 8, 2026
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 8, 2026
rust-timer added a commit that referenced this pull request Jan 8, 2026
Rollup merge of #150736 - atomic-ptr-null, r=joboet

Add AtomicPtr::null

Implementation for #150733.

I marked this function as `#[must_use]` even though the other `AtomicPtr` constructors aren't. It's unclear to me why they aren't already marked as such, I opened a zulip thread asking about it: [#t-libs > Is there a reason AtomicPtr constructors aren't #&#91;must_use&#93;?](https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/Is.20there.20a.20reason.20AtomicPtr.20constructors.20aren't.20.23.5Bmust_use.5D.3F/with/566624261).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants