Skip to content

Fix(lib/win/thread): Ensure Sleep's usage passes over the requested duration under Win7 #150842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
PaulDance wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix(lib/win/thread): Ensure Sleep's usage passes over the requested duration under Win7 #150842

PaulDance wants to merge 1 commit into from
+22 −5

Conversation

@PaulDance
Copy link
Contributor

@PaulDance PaulDance commented Jan 8, 2026 •
edited by rustbot
Loading

Fixes #149935. See the added comment for more details.

I haven't yet exactly been able to test this using a full build under Windows 7 for unrelated reasons, but this should work well as testing separately revealed successful: see the issue.

@rustbot label C-bug I-flaky-test O-windows-7 T-libs A-time A-thread

@PaulDance
Fix(lib/win/thread): Ensure Sleep's usage passes over the requested…
eb101b1 
… duration under Win7

Fixes rust-lang#149935. See the added comment for more details.

Signed-off-by: Paul Mabileau <[email protected]>
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-thread Area: `std::thread` A-time Area: Time C-bug Category: This is a bug. I-flaky-test Issue: A test is flaky/unreliable/spuriously fails O-windows-7 OS: Windows 7 or Windows Server 2008 R2 or etc. labels Jan 8, 2026
@PaulDance PaulDance marked this pull request as ready for review January 8, 2026 23:49
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 8, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 8, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@PaulDance
Copy link
Contributor Author

PaulDance commented Jan 8, 2026

@ChrisDenton might also be interested, as the initial discussion involved him.

lygstate
lygstate reviewed Jan 9, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lygstate lygstate lygstate left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-thread Area: `std::thread` A-time Area: Time C-bug Category: This is a bug. I-flaky-test Issue: A test is flaky/unreliable/spuriously fails O-windows-7 OS: Windows 7 or Windows Server 2008 R2 or etc. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The thread::sleep_until test frequently fails under Windows 7

4 participants

@PaulDance @rustbot @lygstate @Mark-Simulacrum