bootstrap: Ensure documentation is built before tarball is created #150845
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
This comment has been minimized.
This comment has been minimized.
`run_default_doc_steps()` is called to ensure the documentation is built by `Docs::run()` and it should build the documentation if it isn't already built. When running the `install src` command I'm seeing failures as the `builder.doc_out(host)` directory does not exist. This is because `match_paths_to_steps_and_run()` doesn't actually build any documentation as the `paths.is_empty()` causes an early return. This results in install failures as the `*/doc` src directory doesn't exist. This patch passes the paths to `run_host_step_descriptions()` when building documentation to ensure it is correctly built. This fixes installing the Rust source code in OpenEmbedded. Signed-off-by: Alistair Francis <[email protected]>
alistair23
force-pushed
the
alistair/doc-build-fixup
branch
from
e2ed364 to
2e89bf7
Compare
Member
|
r? bootstrap |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_default_doc_steps()is called to ensure the documentation is built byDocs::run()and it should build the documentation if it isn't already built.When running the
install srccommand I'm seeing failures as thebuilder.doc_out(host)directory does not exist. This is becausematch_paths_to_steps_and_run()doesn't actually build any documentation as thepaths.is_empty()causes an early return. This results in install failures as the*/docsrc directory doesn't exist.This patch passes the paths to
run_step_descriptions()when building documentation to ensure it is correctly built.This fixes installing the Rust source code in OpenEmbedded.