include HirIds directly in the THIR, not wrapped in LintLevels
#150846
+163
−182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occurrences of
LintLevelin the THIR were alwaysLintLevel::Explicit, containing aHirId, so we don't need to make it possible to putLintLevel::Inheritedthere. Removing the unused case whereHirIds aren't present in the THIR slightly simplifies diagnostics/lints/tools that want to map from the THIR back to the HIR, e.g. #145569.Since
LintLevelis no longer present in the THIR, I've moved it in the second commit to live inrustc_mir_build; that's where it's actually used. I'm not sure exactly where exactly it should live there, but I put it in thebuilder::scopemodule since it's used byBuilder::in_scopefor determining when to introduce source scopes.r? lcnr as the reviewer of #145569, since this was discussed there