Skip to content

[rustdoc] Make popover menus content scrollable on mobile devices #151216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 3 commits into from
Jan 21, 2026
Merged

[rustdoc] Make popover menus content scrollable on mobile devices #151216

rust-bors merged 3 commits into from
Jan 21, 2026
+61 −11

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jan 16, 2026 •
edited
Loading

Fixes #151209.

This is what it looks like:

image

The only difference with the current display:

image

is that we now see the bottom border (and that we can scroll the content too of course).

I applied this change to both the settings and helps popover menus.

r? @lolbinarycat

@rustbot
Copy link
Collaborator

rustbot commented Jan 16, 2026

Some changes occurred in HTML/CSS/JS.

cc @lolbinarycat

@rustbot rustbot added A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jan 16, 2026
@rustbot

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez changed the title Make popover menus content scrollable on mobile devices [rustdoc] Make popover menus content scrollable on mobile devices Jan 16, 2026
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 16, 2026

Just realized the little "arrow" at the top disappeared. Fixing that.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez GuillaumeGomez force-pushed the scrollable-popover-content branch from b227e14 to 9b340eb Compare January 16, 2026 15:42
@rustbot

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 16, 2026

Fixed it, I moved the overflow-y CSS setting onto the inner content so it doesn't prevent the little arrow to be displayed.

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 16, 2026
Closed
@lolbinarycat
Copy link
Contributor

lolbinarycat commented Jan 19, 2026

First of all, seems pretty good, can't find any faults in the code, and everything seemed to work

@bors r+

Second, manual testing of this change made be realize rustdoc's behavior in regard to changing window sizes has gotten a bit odd lately. First, there's actually 3 different states, the desktop layout, the mobile layout (with the topbar), and an "intermediate" layout with a sidebar, but with the settings and help buttons small in the top right corner, same position they are in when the topbar is around. Transitioning between desktop and intermediate layout with the settings or help menu open works fine, but resizing a window to go to the "mobile" layout forcibly closes these menus.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 19, 2026

📌 Commit 9b340eb has been approved by lolbinarycat

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 20, 2026
@Zalathar
Rollup merge of rust-lang#151216 - scrollable-popover-content, r=lolb…
fda9906 
…inarycat

[rustdoc] Make popover menus content scrollable on mobile devices

Fixes rust-lang#151209.

This is what it looks like:

<img width="468" height="601" alt="image" src="https://github.com/user-attachments/assets/39dcbfea-ca31-4875-947f-155b58ffa4bd" />

The only difference with the current display:

<img width="468" height="601" alt="image" src="https://github.com/user-attachments/assets/b49c6100-3566-4f79-8343-1bf4fe32da78" />

is that we now see the bottom border (and that we can scroll the content too of course).

I applied this change to both the settings and helps popover menus.

r? @lolbinarycat
@Zalathar Zalathar mentioned this pull request Jan 20, 2026
Closed
@Zalathar
Copy link
Member

Zalathar commented Jan 20, 2026

Failed in rollup? #151392 (comment)

@bors r-
@bors try jobs=x86_64-gnu-tools

@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 20, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 20, 2026

Commit 9b340eb has been unapproved.

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 20, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Jan 20, 2026
@bors
Auto merge of #151216 - GuillaumeGomez:scrollable-popover-content, r=…
71076f5 
…<try>

[rustdoc] Make popover menus content scrollable on mobile devices


try-job: x86_64-gnu-tools
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 20, 2026

☀️ Try build successful (CI)
Build commit: 71076f5 (71076f528892b464bf64642e0d117515b717ac86, parent: 058a763dd295a4ea6a8d0c94e326d852e32f52ea)

@Zalathar
Copy link
Member

Zalathar commented Jan 20, 2026

Hmm, looks like either a flaky test or a soft-conflict in the rollup.

@GuillaumeGomez GuillaumeGomez force-pushed the scrollable-popover-content branch from 9b340eb to 76ea822 Compare January 20, 2026 13:35
@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot
Copy link
Collaborator

rustbot commented Jan 20, 2026

⚠️ Warning ⚠️

  • There are issue links (such as #123) in the commit messages of the following commits.
    Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 20, 2026

Seems like a rebase was needed, gonna check locally then.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jan 20, 2026

@bors r=lolbinarycat rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 20, 2026

📌 Commit d5bacdd has been approved by lolbinarycat

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 20, 2026
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 20, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 20, 2026
@bors
Auto merge of #151427 - GuillaumeGomez:rollup-HAeLPDZ, r=GuillaumeGomez
af6695c 
Rollup of 7 pull requests

Successful merges:

 - #151216 ([rustdoc] Make popover menus content scrollable on mobile devices)
 - #151373 (Fix an ICE on transmute goals with placeholders in `param_env`)
 - #151399 (Generate error delegation when delegation is not resolved)
 - #151406 (Use version 1.93.0 in `RELEASES.md` instead of 1.93)
 - #151410 (Fixes for LLVM 22 compatibility)
 - #151415 (chore: Remove redundant conversion)
 - #151418 (Avoid pulling in unicode when calling io::Error::kind)

r? @ghost
@rust-bors rust-bors bot merged commit e965bca into rust-lang:main Jan 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 21, 2026
rust-timer added a commit that referenced this pull request Jan 21, 2026
@rust-timer
Unrolled build for #151216
7455076 
Rollup merge of #151216 - scrollable-popover-content, r=lolbinarycat

[rustdoc] Make popover menus content scrollable on mobile devices

Fixes #151209.

This is what it looks like:

<img width="468" height="601" alt="image" src="https://github.com/user-attachments/assets/39dcbfea-ca31-4875-947f-155b58ffa4bd" />

The only difference with the current display:

<img width="468" height="601" alt="image" src="https://github.com/user-attachments/assets/b49c6100-3566-4f79-8343-1bf4fe32da78" />

is that we now see the bottom border (and that we can scroll the content too of course).

I applied this change to both the settings and helps popover menus.

r? @lolbinarycat
@GuillaumeGomez GuillaumeGomez deleted the scrollable-popover-content branch January 21, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lolbinarycat lolbinarycat

Labels

A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

Dropdown menus overflow screen on mobile and can't be scrolled

5 participants

@GuillaumeGomez @rustbot @rust-log-analyzer @lolbinarycat @Zalathar