constify Iterator, take IV
#151281
Merged
constify Iterator, take IV
#151281
+276
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred to the CTFE machinery Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-libs
Collaborator
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
push-zmqtzvuvlmuk
branch
from
7bbe4b2 to
c068979
Compare
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
push-zmqtzvuvlmuk
branch
from
c068979 to
672348d
Compare
RalfJung
reviewed
Jan 18, 2026
| /// ``` | ||
| #[inline] | ||
| #[unstable(feature = "iter_next_chunk", issue = "98326")] | ||
| #[rustc_non_const_trait_method] |
Member
There was a problem hiding this comment.
Please also update the dev-guide docs to explain the attribute.
RalfJung
reviewed
Jan 18, 2026
This comment has been minimized.
This comment has been minimized.
juntyr
reviewed
Jan 18, 2026
| rustc_non_const_trait_method, AttributeType::Normal, template!(Word), | ||
| ErrorFollowing, EncodeCrossCrate::No, | ||
| "`#[rustc_non_const_trait_method]` should only used by the standard library to mark trait methods \ | ||
| as non-const to allow large traits to easier transition to const" |
Contributor
There was a problem hiding this comment.
"traits an easier transition" or "traits to transition more easily"
fee1-dead
force-pushed
the
push-zmqtzvuvlmuk
branch
from
672348d to
aed44b6
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
fee1-dead
force-pushed
the
push-zmqtzvuvlmuk
branch
from
fa9f21b to
d8c7329
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
Member
|
r? @oli-obk
|
This comment was marked as resolved.
This comment was marked as resolved.
oli-obk
reviewed
Jan 27, 2026
oli-obk
approved these changes
Jan 27, 2026
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
push-zmqtzvuvlmuk
branch
from
d8c7329 to
02e10b2
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@bors r=oli-obk |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-timer
added a commit
that referenced
this pull request
Jan 31, 2026
Rollup merge of #151281 - fee1-dead-contrib:push-zmqtzvuvlmuk, r=oli-obk constify `Iterator`, take IV Like its predecessors (#92433, #102225, #106541), this PR allows one to make `Iterator` implementations `const`, and thus enables the ability to have `for` loops in `const` contexts. I've also included constifying `Option as IntoIterator`, `option::IntoIter as Iterator` as a minimal dogfooding example. But unlike its predecessors, it uses a new attribute (not unsound anymore!) that prevents any `Iterator` extension methods from being called. This is intentionally made minimal for an initial approval, the fun stuff like `.fold`, `Range as Iterator` could be done later. cc @rust-lang/wg-const-eval, cc @oli-obk to review the compiler parts cc #92476
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jan 31, 2026
…uwer Rollup of 2 pull requests Successful merges: - rust-lang/rust#151281 (constify `Iterator`, take IV) - rust-lang/rust#151873 (resolve: Remove `force` parameter from `resolve_ident_in_scope`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like its predecessors (#92433, #102225, #106541), this PR allows one to make
Iteratorimplementationsconst, and thus enables the ability to haveforloops inconstcontexts. I've also included constifyingOption as IntoIterator,option::IntoIter as Iteratoras a minimal dogfooding example.But unlike its predecessors, it uses a new attribute (not unsound anymore!) that prevents any
Iteratorextension methods from being called. This is intentionally made minimal for an initial approval, the fun stuff like.fold,Range as Iteratorcould be done later.cc @rust-lang/wg-const-eval, cc @oli-obk to review the compiler parts
cc #92476