trait_selection: fix type-const eval ICE #152040
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
Collaborator
|
|
JohnTitor
commented
Feb 3, 2026
| if !type_const_stack.insert(uv.def) { | ||
| let guar = tcx.dcx().span_err( | ||
| tcx.def_span(uv.def), | ||
| "cycle detected when evaluating type-level constant", |
Member
Author
There was a problem hiding this comment.
I'm not sure if we should detect a cyclic error in this place though, maybe we can handle it better?
Contributor
|
Does this code compiles under your impl? |
JohnTitor
force-pushed
the
issue-151631
branch
from
3fc70e5 to
e853189
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
@Human9000-bit Yeah, it should. Added a rev so that we can make sure it. |
Contributor
|
☔ The latest upstream changes (presumably #152373) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151631, fixes #151477
r? @fmease
I'd recommend reviewing commit-by-commit, the diff is less-readable to address a cyclic issue.