-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
update compiler stable backport zulip msg #152182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update compiler stable backport zulip msg #152182
Conversation
|
|
|
rustbot has assigned @Mark-Simulacrum. Use |
|
The job Click to see the possible cause of the failure (guessed by this bot) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ckport-zulip-msg, r=jieyouxu update compiler stable backport zulip msg I'd like to update the message when stable backports (for t-compiler) Zulip topics are opened. Stable backports mention the channel i.e. also people who might not have context, example: [#t-compiler/backports > rust-lang#150590: stable-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23150590.3A.20stable-nominated/near/569989784) Beta backports mention author+reviewer (which fits better), example: [#t-compiler/backports > rust-lang#151896: beta-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23151896.3A.20beta-nominated/near/571171604) This patch makes the `stable` backport opening message just like the `beta` backport one. Thanks
…ckport-zulip-msg, r=jieyouxu update compiler stable backport zulip msg I'd like to update the message when stable backports (for t-compiler) Zulip topics are opened. Stable backports mention the channel i.e. also people who might not have context, example: [#t-compiler/backports > rust-lang#150590: stable-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23150590.3A.20stable-nominated/near/569989784) Beta backports mention author+reviewer (which fits better), example: [#t-compiler/backports > rust-lang#151896: beta-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23151896.3A.20beta-nominated/near/571171604) This patch makes the `stable` backport opening message just like the `beta` backport one. Thanks
…uwer Rollup of 13 pull requests Successful merges: - #152191 (Convert to inline diagnostics in `rustc_hir_analysis`) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152140 (Hard code the error code registry for custom drivers) - #152155 (Fix typos in riscv64a23-unknown-linux-gnu.md) - #152170 (Port `rustc_effective_visibility` to the new attribute parser) - #152182 (update compiler stable backport zulip msg) - #152184 (Port rustc_abi to the attribute parser) - #152195 (update openmp/offload builds to LLVM 22, Part 1) - #152202 (chore: clearify tidy's error message) Failed merges: - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152212 (Port some attributes to the attr parser)
Rollup merge of #152182 - apiraino:update-compiler-stable-backport-zulip-msg, r=jieyouxu update compiler stable backport zulip msg I'd like to update the message when stable backports (for t-compiler) Zulip topics are opened. Stable backports mention the channel i.e. also people who might not have context, example: [#t-compiler/backports > #150590: stable-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23150590.3A.20stable-nominated/near/569989784) Beta backports mention author+reviewer (which fits better), example: [#t-compiler/backports > #151896: beta-nominated @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/474880-t-compiler.2Fbackports/topic/.23151896.3A.20beta-nominated/near/571171604) This patch makes the `stable` backport opening message just like the `beta` backport one. Thanks
I'd like to update the message when stable backports (for t-compiler) Zulip topics are opened.
Stable backports mention the channel i.e. also people who might not have context, example:
#t-compiler/backports > #150590: stable-nominated @ 💬
Beta backports mention author+reviewer (which fits better), example:
#t-compiler/backports > #151896: beta-nominated @ 💬
This patch makes the
stablebackport opening message just like thebetabackport one.Thanks