Make all multipart suggestions verbose#152596
Open
estebank wants to merge 1 commit intorust-lang:mainfrom
Open
Make all multipart suggestions verbose#152596estebank wants to merge 1 commit intorust-lang:mainfrom
estebank wants to merge 1 commit intorust-lang:mainfrom
Conversation
The ShowAlways style of suggestions is usually easier to understand than the inline style.
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in match checking cc @Nadrieril HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @petrochenkov. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
|
☔ The latest upstream changes (presumably #152627) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
This is good, I never understood the logic behind choosing between r=me after rebasing and making CI green. |
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Contributor
Author
Honestly, inertia. The initial suggestion rendering was inline. Much later, I introduced the verbose mode for specific cases. Since then, the verbose mode became much better, to the point where it makes sense for it to be the default in most cases. There's a handful of cases where the inline suggestions make more sense (when it is a single word being changed, mainly). The multipart suggestion was introduced when inline was the better mode. This switch makes sense to me given how much easier to read the patch format is (specially because it makes incorrect suggestion spans more evident!). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ShowAlways style of suggestions is usually easier to understand than the inline style.