Skip to content

Comments

Rename DepGraphQuery to RetainedDepGraph#152844

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Zalathar:retain-dep-graph
Feb 20, 2026
Merged

Rename DepGraphQuery to RetainedDepGraph#152844
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Zalathar:retain-dep-graph

Conversation

@Zalathar
Copy link
Member

This is a revised subset of #152836 that only performs an internal renaming, and does not touch the -Zquery-dep-graph flag.

The new name and comments for RetainedDepGraph should hopefully do a better job of communicating that it is not used in normal compiler operation, even in incremental mode.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2026

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, incremental
  • compiler, incremental expanded to 68 candidates
  • Random selection from 15 candidates

Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📌 Commit d4bff25 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 20, 2026
@rust-bors

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Zalathar
Copy link
Member Author

Rebased to fix trivial import conflict.

@bors r=JonathanBrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 20, 2026

📌 Commit 19e0c62 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 20, 2026
rust-bors bot pushed a commit that referenced this pull request Feb 20, 2026
…uwer

Rollup of 11 pull requests

Successful merges:

 - #152759 (Simpler `find_attr!()`)
 - #152057 (bootstrap: respect POSIX jobserver)
 - #152818 (DOC: do not link to "nightly" in Iterator::by_ref() docstring)
 - #152840 (Add bootstrap snapshot tests for {`install`, `install src`})
 - #152844 (Rename `DepGraphQuery` to `RetainedDepGraph`)
 - #152846 (Clarify some variable names in the query proc-macro)
 - #152858 (Fix typo in doc for core::mem::type_info::Struct)
 - #152861 (resolve: do not suggest `_` for unresolved imports)
 - #152873 (std::ops::ControlFlow - use "a" before `Result`)
 - #152877 (std::ops::ControlFlow - use normal comment for internal methods)
 - #152883 (Deny final not followed by item)
@rust-bors rust-bors bot merged commit eb5f275 into rust-lang:main Feb 20, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 20, 2026
rust-timer added a commit that referenced this pull request Feb 20, 2026
Rollup merge of #152844 - Zalathar:retain-dep-graph, r=JonathanBrouwer

Rename `DepGraphQuery` to `RetainedDepGraph`

This is a revised subset of #152836 that only performs an internal renaming, and does not touch the `-Zquery-dep-graph` flag.

The new name and comments for `RetainedDepGraph` should hopefully do a better job of communicating that it is not used in normal compiler operation, even in incremental mode.
@Zalathar Zalathar deleted the retain-dep-graph branch February 21, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants