Migration of `LintDiagnostic` - part 3 by GuillaumeGomez · Pull Request #153051 · rust-lang/rust

GuillaumeGomez · 2026-02-24T14:48:34Z

Follow-up of #152933 and of #153016.

More LintDiagnostic items being migrated to Diagnostic. Since there is no remaining emit_node_span_lint calls, I replaced the method with the code of emit_diag_node_span_lint.

r? @JonathanBrouwer

rustbot · 2026-02-24T14:48:37Z

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

HIR ty lowering was modified

cc @fmease

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in exhaustiveness checking

cc @Nadrieril

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

rustbot · 2026-02-24T14:48:40Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

compiler/rustc_middle/src/middle/stability.rs

compiler/rustc_trait_selection/src/error_reporting/traits/on_unimplemented_format.rs

JonathanBrouwer

r=me if you don't need significant changes to fix CI

View changes since this review

JonathanBrouwer · 2026-02-24T17:24:14Z

@bors r+ rollup

rust-bors · 2026-02-24T17:24:17Z

📌 Commit 0b31e99 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…lint`

…int`

GuillaumeGomez · 2026-02-24T19:34:39Z

Rebased.

rustbot · 2026-02-24T19:34:40Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-02-24T20:22:52Z

@bors r+ rollup

rust-bors · 2026-02-24T20:22:55Z

📌 Commit 8fa1fca has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…athanBrouwer Migration of `LintDiagnostic` - part 3 Follow-up of rust-lang#152933 and of rust-lang#153016. More `LintDiagnostic` items being migrated to `Diagnostic`. Since there is no remaining `emit_node_span_lint` calls, I replaced the method with the code of `emit_diag_node_span_lint`. r? @JonathanBrouwer

Rollup of 8 pull requests Successful merges: - #149169 (ptr::replace: make calls on ZST null ptr not UB) - #150562 (Fix doc link used in suggestion for pinning self) - #152679 (rustc_expand: improve diagnostics for non-repeatable metavars) - #153017 (Implement debuginfo for unsafe binder types) - #152868 (delete some very old trivial `Box` tests) - #152922 (rustc_public: Make fields that shouldn't be exposed visible only in `rustc_public`) - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - #153051 (Migration of `LintDiagnostic` - part 3)

Rollup of 12 pull requests Successful merges: - #149169 (ptr::replace: make calls on ZST null ptr not UB) - #150562 (Fix doc link used in suggestion for pinning self) - #152418 (`BTreeMap::merge` optimized) - #152679 (rustc_expand: improve diagnostics for non-repeatable metavars) - #152952 (mGCA: improve ogca diagnostic message ) - #152977 (Fix relative path handling for --extern-html-root-url) - #153017 (Implement debuginfo for unsafe binder types) - #152868 (delete some very old trivial `Box` tests) - #152922 (rustc_public: Make fields that shouldn't be exposed visible only in `rustc_public`) - #153032 (Fix attribute parser and kind names.) - #153051 (Migration of `LintDiagnostic` - part 3) - #153060 (Give a better error when updating a submodule fails)

@JonathanBrouwer

Rollup merge of #153051 - GuillaumeGomez:migrate-diag, r=JonathanBrouwer Migration of `LintDiagnostic` - part 3 Follow-up of #152933 and of #153016. More `LintDiagnostic` items being migrated to `Diagnostic`. Since there is no remaining `emit_node_span_lint` calls, I replaced the method with the code of `emit_diag_node_span_lint`. r? @JonathanBrouwer

Kobzol · 2026-02-25T11:24:55Z

@rust-timer build 86e0932

For #153074.

rust-timer · 2026-02-25T11:24:58Z

Missing artifact for sha 86e09325d662b75983bdc4be7f758cbcbb8509a3 (https://ci-artifacts.rust-lang.org/rustc-builds/86e09325d662b75983bdc4be7f758cbcbb8509a3/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz); not built yet, try again later.

GuillaumeGomez · 2026-02-25T11:58:22Z

@rust-timer build 8fa1fca

rust-timer · 2026-02-25T11:58:25Z

Missing artifact for sha [8fa1fca](https://github.com/rust-lang/rust/pull/153051/commits/8fa1fca9f6e0f903ed4e90f5b131433b992d8495) (https://ci-artifacts.rust-lang.org/rustc-builds/[8fa1fca](https://github.com/rust-lang/rust/pull/153051/commits/8fa1fca9f6e0f903ed4e90f5b131433b992d8495)/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz); not built yet, try again later.

GuillaumeGomez · 2026-02-25T11:58:58Z

@rust-timer build 8fa1fca

rust-timer · 2026-02-25T11:59:00Z

Missing artifact for sha 8fa1fca9f6e0f903ed4e90f5b131433b992d8495 (https://ci-artifacts.rust-lang.org/rustc-builds/8fa1fca9f6e0f903ed4e90f5b131433b992d8495/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz); not built yet, try again later.

GuillaumeGomez · 2026-02-25T11:59:08Z

Hum ok.

JonathanBrouwer · 2026-02-25T12:08:37Z

@rust-timer build 86e0932

(86e0932 is the built commit from the rollup, which is the one we should be benchmarking)

rust-timer · 2026-02-25T12:48:50Z

Finished benchmarking commit (86e0932): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -5.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.4%	[-7.2%, -4.4%]	3
All ❌✅ (primary)	-	-	0

Cycles

Results (primary -3.1%, secondary -3.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.1%	[-3.1%, -3.1%]	1
Improvements ✅ (secondary)	-3.3%	[-4.7%, -2.6%]	5
All ❌✅ (primary)	-3.1%	[-3.1%, -3.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 482.035s -> 482.3s (0.05%)
Artifact size: 397.81 MiB -> 395.79 MiB (-0.51%)

@JonathanBrouwer

…athanBrouwer Migration of `LintDiagnostic` - part 4 Follow-up of: * rust-lang#152933 * rust-lang#153016 * rust-lang#153051 More `LintDiagnostic` items being migrated to `Diagnostic`. Since there is no remaining `emit_node_span_lint` calls, I replaced the method with the code of `emit_diag_node_span_lint`. r? @JonathanBrouwer

@JonathanBrouwer

…athanBrouwer Migration of `LintDiagnostic` - part 4 Follow-up of: * rust-lang#152933 * rust-lang#153016 * rust-lang#153051 More `LintDiagnostic` items being migrated to `Diagnostic`. Since there is no remaining `emit_node_span_lint` calls, I replaced the method with the code of `emit_diag_node_span_lint`. r? @JonathanBrouwer

@JonathanBrouwer

Rollup merge of #153091 - GuillaumeGomez:migrate-diag, r=JonathanBrouwer Migration of `LintDiagnostic` - part 4 Follow-up of: * #152933 * #153016 * #153051 More `LintDiagnostic` items being migrated to `Diagnostic`. Since there is no remaining `emit_node_span_lint` calls, I replaced the method with the code of `emit_diag_node_span_lint`. r? @JonathanBrouwer

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 24, 2026

rustbot assigned JonathanBrouwer Feb 24, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer reviewed Feb 24, 2026

View reviewed changes

compiler/rustc_middle/src/middle/stability.rs Show resolved Hide resolved

compiler/rustc_trait_selection/src/error_reporting/traits/on_unimplemented_format.rs Outdated Show resolved Hide resolved

JonathanBrouwer approved these changes Feb 24, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

GuillaumeGomez added 10 commits February 24, 2026 20:12

Migrate rustc_privacy to use TyCtxt::emit_diag_node_span_lint

327f778

Migrate rustc_pattern_analysis to use `TyCtxt::emit_diag_node_span_…

c53fbcd

…lint`

Migrate rustc_lint to use TyCtxt::emit_diag_node_span_lint

b55f6e3

Migrate rustc_mir_build to use TyCtxt::emit_diag_node_span_lint

d926c1b

Migrate rustc_mir_transform to use TyCtxt::emit_diag_node_span_lint

480aa4d

Migrate rustc_monomorphize to use TyCtxt::emit_diag_node_span_lint

f02ce96

Migrate rustc_passes to use TyCtxt::emit_diag_node_span_lint

8f63c00

Migrate rustc_trait_selection to use `TyCtxt::emit_diag_node_span_l…

1c6c0f7

…int`

Replace TyCtxt::emit_node_span_lint with emit_diag_node_span_lint

2bb3b01

Apply new change from lint_level into diag_lint_level

8fa1fca

GuillaumeGomez force-pushed the migrate-diag branch from 0b31e99 to 8fa1fca Compare February 24, 2026 19:34

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2026

GuillaumeGomez mentioned this pull request Feb 24, 2026

Rollup of 8 pull requests #153059

Closed

jhpratt mentioned this pull request Feb 25, 2026

Rollup of 12 pull requests #153074

Merged

rust-bors bot merged commit 6929f76 into rust-lang:main Feb 25, 2026
11 checks passed

rustbot added this to the 1.95.0 milestone Feb 25, 2026

GuillaumeGomez deleted the migrate-diag branch February 25, 2026 09:54

This comment has been minimized.

Sign in to view

GuillaumeGomez mentioned this pull request Feb 25, 2026

Migration of LintDiagnostic - part 4 #153091

Merged

JonathanBrouwer mentioned this pull request Feb 25, 2026

Tracking Issue for LintDiagnostic migration #153099

Open

1 task

Uh oh!

Conversation

GuillaumeGomez commented Feb 24, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 24, 2026

Uh oh!

rustbot commented Feb 24, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

JonathanBrouwer left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwer commented Feb 24, 2026

Uh oh!

rust-bors bot commented Feb 24, 2026

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Feb 24, 2026

Uh oh!

rustbot commented Feb 24, 2026

Uh oh!

JonathanBrouwer commented Feb 24, 2026

Uh oh!

rust-bors bot commented Feb 24, 2026

Uh oh!

Uh oh!

Kobzol commented Feb 25, 2026

Uh oh!

rust-timer commented Feb 25, 2026

Uh oh!

GuillaumeGomez commented Feb 25, 2026

Uh oh!

rust-timer commented Feb 25, 2026

Uh oh!

GuillaumeGomez commented Feb 25, 2026

Uh oh!

rust-timer commented Feb 25, 2026

Uh oh!

GuillaumeGomez commented Feb 25, 2026

Uh oh!

JonathanBrouwer commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

rust-timer commented Feb 25, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

GuillaumeGomez commented Feb 24, 2026 •

edited by rustbot

Loading

JonathanBrouwer left a comment •

edited by rustbot

Loading

JonathanBrouwer commented Feb 25, 2026 •

edited

Loading