Closed
Conversation
* add --ci flag in tidy This commit introduces --ci flag in tidy because currently bootstrap can't pass its ci env information to tidy. It also modifies how CiInfo initialize its ci_env variable. tidy codes which uses CiEnv::is_ci for checking ci are now using ci_env in CiInfo. * address review - Fix comment - Use Option for ci flag in order to have true/false explicitly or unspecified (implicit false) * integrate CiInfo into TidyCtx * remove CiInfo * CiEnv::current() should be called when ci flag is not added * extract base_commit() to a separate function * use &TidyCtx instead of clone
It's unused.
It has a single use.
This makes it clear the `CycleError` is not used after the call.
When there are two cases of equal size and importance, I find an if/else expression easier to read than an early return.
It reads better that way.
It's an unnecessary level of indirection.
Calling `abort_if_errors` after emitting an error is guaranteed to call `raise_fatal`, so just do that directly instead.
This exact comment block also appears in `compiler/rustc_middle/src/queries.rs`, which is a better place for it.
`Value` is an unhelpfully generic name. Standard naming procedure for a trait with a single method is for the trait name to match the method name, which is what this commit does. Likewise, the enclosing module is renamed from `values` to `from_cycle_error`. Also add a comment about some non-obvious behaviour.
It has no effect. `symbol_name` is the only query that produces a `SymbolName`. If it was marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError` impl would make sense, but that's not the case. Maybe it was the case in the past.
…-closure-suggestion, r=JohnTitor Suggest async block instead of async closure when possible Fixes rust-lang#140265 r? @estebank
Introduce --ci flag in tidy ## Context Currently tidy doesn't have `--ci` flag. Even if bootstrap has --ci=true, it isn't passed to tidy. As a result, some parts of tidy where we need to turn on `ci mode` are never executed on our local. ## Change This PR introduces --ci flag in tidy, and modify CiInfo and other parts of tidy where currently use `CiEnv::is_ci()` for checking if the running environment is ci or not.
…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk
…51509, r=nnethercote Disable debug_assert_not_in_new_nodes for multiple threads Fixes rust-lang#152654 This debug assertion is no longer intended to succeed for the parallel compiler since rust-lang#151509 doesn't panic on a red-green query graph coloring race, generating both red and green nodes (rust-lang#151509 (comment))
rustfmt: add test for field representing type builtin syntax As requested by @ytmimi in rust-lang#152730 (comment). Not sure if you want/need a more complex example. Just let me know.
rustbot
added
A-query-system
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Contributor
|
PR #153169, which is a member of this rollup, was unapproved. |
Contributor
|
☔ The latest upstream changes (presumably #153114) made this pull request unmergeable. Please resolve the merge conflicts. |
rustbot
removed
the
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
QueryVTable::hash_resultintohash_value_fn#153209 (Clean upQueryVTable::hash_resultintohash_value_fn)r? @ghost
Create a similar rollup