enable PassMode::Indirect { on_stack: true, .. } tail call arguments#153361
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 5, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
35 tasks
WaffleLapkin
reviewed
Mar 4, 2026
Comment on lines
-1297
to
-1301
| // FIXME: some LLVM backends (notably x86) do not correctly pass byval | ||
| // arguments to tail calls (as of LLVM 21). See also: | ||
| // | ||
| // - https://github.com/rust-lang/rust/pull/144232#discussion_r2218543841 | ||
| // - https://github.com/rust-lang/rust/issues/144855 |
Member
There was a problem hiding this comment.
Is this comment not accurate anymore, shouldn't we wait until we don't support llvm 21 anymore?
Contributor
Author
There was a problem hiding this comment.
you can only use tail calls with nightly, which builds with the latest LLVM? We'll need to wait until we don't support LLVM 21 (or higher, given that e.g. riscv will only add support in LLVM 23) for stabilization, but not for experimentation.
WaffleLapkin
approved these changes
Mar 4, 2026
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 4, 2026
…tack-true, r=WaffleLapkin
enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments
tracking issue: rust-lang#112788
fixes rust-lang#144855
And add a bunch of tests for tail call target support.
r? WaffleLapkin
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 4, 2026
…tack-true, r=WaffleLapkin
enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments
tracking issue: rust-lang#112788
fixes rust-lang#144855
And add a bunch of tests for tail call target support.
r? WaffleLapkin
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 4, 2026
…tack-true, r=WaffleLapkin
enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments
tracking issue: rust-lang#112788
fixes rust-lang#144855
And add a bunch of tests for tail call target support.
r? WaffleLapkin
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Mar 4, 2026
…tack-true, r=WaffleLapkin
enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments
tracking issue: rust-lang#112788
fixes rust-lang#144855
And add a bunch of tests for tail call target support.
r? WaffleLapkin
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2026
Rollup of 9 pull requests Successful merges: - #152164 (Lint unused features) - #152801 (Refactor WriteBackendMethods a bit) - #153317 (Abort after `representability` errors) - #153361 (enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments) - #153402 (miri subtree update) - #153276 (Remove `cycle_fatal` query modifier) - #153396 (use `minicore` in some `run-make` tests) - #153401 (Migrationg of `LintDiagnostic` - part 7) - #153406 (Remove a ping for myself)
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2026
Rollup of 9 pull requests Successful merges: - #152164 (Lint unused features) - #152801 (Refactor WriteBackendMethods a bit) - #153317 (Abort after `representability` errors) - #153361 (enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments) - #153402 (miri subtree update) - #153276 (Remove `cycle_fatal` query modifier) - #153396 (use `minicore` in some `run-make` tests) - #153401 (Migrationg of `LintDiagnostic` - part 7) - #153406 (Remove a ping for myself)
Contributor
rust-bors
bot
added
S-waiting-on-author
Contributor
folkertdev
force-pushed
the
tail-call-indirect-on-stack-true
branch
from
e78a9f7 to
391a755
Compare
Contributor
Author
|
Having a @bors try jobs=test-various |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 4, 2026
…r=<try>
enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments
try-job: test-various
Contributor
Contributor
Author
|
@bors r=WaffleLapkin |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
…uwer Rollup of 8 pull requests Successful merges: - #153361 (enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments) - #153369 (library/test: always enable unstable features for miri) - #152283 (Properly pass offload sizes to kernel args) - #153323 (Remove `impl QueryVTable`) - #153385 (Fix comment on `is_horizontal_whitespace`) - #153394 (fix(thir): Include `NoneWithError` in Enum Struct Tail Assertion) - #153419 (rustc_llvm: add missing `-` to flag-comparison logic) - #153423 (Update dispatch2 to v0.3.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #112788
fixes #144855
And add a bunch of tests for tail call target support.
r? WaffleLapkin