rustc_llvm: add missing - to flag-comparison logic#153419
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Mar 5, 2026
Merged
rustc_llvm: add missing - to flag-comparison logic#153419rust-bors[bot] merged 1 commit intorust-lang:mainfrom
- to flag-comparison logic#153419rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
The build script here wants to sniff for `-stdlib=libc++` but was missing the leading dashes. We caught this on the Rust/LLVM HEADs builder which also uses libc++.
rustbot
added
A-LLVM
Collaborator
|
r? @cuviper rustbot has assigned @cuviper. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
@rustbot label: +llvm-main (not really llvm-main specific, but blocking our CI from passing) |
rustbot
added
the
llvm-main
Member
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 5, 2026
…uwer Rollup of 8 pull requests Successful merges: - #153361 (enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments) - #153369 (library/test: always enable unstable features for miri) - #152283 (Properly pass offload sizes to kernel args) - #153323 (Remove `impl QueryVTable`) - #153385 (Fix comment on `is_horizontal_whitespace`) - #153394 (fix(thir): Include `NoneWithError` in Enum Struct Tail Assertion) - #153419 (rustc_llvm: add missing `-` to flag-comparison logic) - #153423 (Update dispatch2 to v0.3.1)
rust-timer
added a commit
that referenced
this pull request
Mar 5, 2026
Rollup merge of #153419 - durin42:missing-dashes, r=cuviper rustc_llvm: add missing `-` to flag-comparison logic The build script here wants to sniff for `-stdlib=libc++` but was missing the leading dashes. We caught this on the Rust/LLVM HEADs builder which also uses libc++.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 5, 2026
…risDenton Use shlex instead of shell-words In rust-lang#152712, the [`shell-words`] crate was introduced as a new dependency of `rustc_llvm` in order for its build script to parse the output of `llvm-config --quote-paths` and thereby handle paths containing whitespace; however, as [noted by bjorn3], that build script already transitively depends upon the [`shlex`] crate (via the [`cc`] crate) which provides similar functionality. This patch is based off (the already-approved) rust-lang#153419, which would otherwise conflict. [`cc`]: https://crates.io/crates/cc [noted by bjorn3]: rust-lang#152712 (comment) [`shell-words`]: https://crates.io/crates/shell-words [`shlex`]: https://crates.io/crates/shlex r? ChrisDenton
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 5, 2026
…risDenton Use shlex instead of shell-words In rust-lang#152712, the [`shell-words`] crate was introduced as a new dependency of `rustc_llvm` in order for its build script to parse the output of `llvm-config --quote-paths` and thereby handle paths containing whitespace; however, as [noted by bjorn3], that build script already transitively depends upon the [`shlex`] crate (via the [`cc`] crate) which provides similar functionality. This patch is based off (the already-approved) rust-lang#153419, which would otherwise conflict. [`cc`]: https://crates.io/crates/cc [noted by bjorn3]: rust-lang#152712 (comment) [`shell-words`]: https://crates.io/crates/shell-words [`shlex`]: https://crates.io/crates/shlex r? ChrisDenton
rust-timer
added a commit
that referenced
this pull request
Mar 5, 2026
Rollup merge of #153436 - eggyal:shlex-not-shell_words, r=ChrisDenton Use shlex instead of shell-words In #152712, the [`shell-words`] crate was introduced as a new dependency of `rustc_llvm` in order for its build script to parse the output of `llvm-config --quote-paths` and thereby handle paths containing whitespace; however, as [noted by bjorn3], that build script already transitively depends upon the [`shlex`] crate (via the [`cc`] crate) which provides similar functionality. This patch is based off (the already-approved) #153419, which would otherwise conflict. [`cc`]: https://crates.io/crates/cc [noted by bjorn3]: #152712 (comment) [`shell-words`]: https://crates.io/crates/shell-words [`shlex`]: https://crates.io/crates/shlex r? ChrisDenton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build script here wants to sniff for
-stdlib=libc++but was missing the leading dashes. We caught this on the Rust/LLVM HEADs builder which also uses libc++.