fix: don't add trailing comma after .. in struct pattern suggestion#153501
Closed
KernelKraze wants to merge 1 commit intorust-lang:mainfrom
Closed
fix: don't add trailing comma after .. in struct pattern suggestion#153501KernelKraze wants to merge 1 commit intorust-lang:mainfrom
.. in struct pattern suggestion#153501KernelKraze wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
…stion When the last field in the pattern already has a trailing comma, the suggestion was appending `, ..` after the field span, producing `field, ..,` which is invalid. Check for an existing comma in the source and insert ` ..` after it instead.
KernelKraze
force-pushed
the
contribute/fix-dotdot-trailing-comma-suggestion
branch
from
b38897d to
d357f94
Compare
Member
|
can you please add a test to reflect new behaviour |
Contributor
|
I'm pretty sure this is already handled in #151280, which is on its way to be merged. |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the last listed field has a trailing comma, the suggestion for
"pattern requires
..due to inaccessible fields" was producingfield, ..,, which doesn't compile.Before:
After:
Fixes #149787
r? @estebank