Create compilation target versions of `::alloc::Layout` #64299

Dante-Broggi · 2019-09-09T00:49:00Z

This PR adds 2 types LayoutPositionPref and MemoryPosition which are like ::alloc::Layout but use layout::Size and layout::{AbiAndPrefAlign, Align}, and replaces most pairs of Size and *Align with one of them.

Most of the commits are semi-minimal changes after changing a single (group of) APIs, which is why there are so many of them. If desired they could be squashed.

Edit: also, each commit (in order) satisfies at least “./x.py check -i”.

Overall, other than API breakage, this is almost a pure refactoring, the only difference should be that I changed many places to be more correct for non-stride (.size != .size.aligned_to(.align)) sizes, which IIRC Rust currently does not allow anyway.

rust-highfive · 2019-09-09T00:49:04Z

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-09-09T01:10:25Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-09T00:49:42.8978572Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-09T00:49:42.9165247Z ##[command]git config gc.auto 0
2019-09-09T00:49:42.9232034Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-09T00:49:42.9274343Z ##[command]git config --get-all http.proxy
2019-09-09T00:49:42.9405130Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64299/merge:refs/remotes/pull/64299/merge
---
2019-09-09T00:56:30.7727351Z    Compiling serde_json v1.0.40
2019-09-09T00:56:32.3814842Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-09-09T00:56:42.3686758Z     Finished release [optimized] target(s) in 1m 23s
2019-09-09T00:56:42.3756111Z tidy check
2019-09-09T00:56:42.4953009Z tidy error: /checkout/src/librustc_target/abi/mod.rs:552: line longer than 100 chars
2019-09-09T00:56:42.4954228Z tidy error: /checkout/src/librustc_target/abi/mod.rs:681: line longer than 100 chars
2019-09-09T00:56:42.9383305Z tidy error: /checkout/src/librustc/mir/interpret/allocation.rs:507: line longer than 100 chars
2019-09-09T00:56:42.9592234Z tidy error: /checkout/src/librustc/ty/layout.rs:245: trailing whitespace
2019-09-09T00:56:42.9593568Z tidy error: /checkout/src/librustc/ty/layout.rs:250: trailing whitespace
2019-09-09T00:56:42.9593639Z tidy error: /checkout/src/librustc/ty/layout.rs:309: trailing whitespace
2019-09-09T00:56:42.9593712Z tidy error: /checkout/src/librustc/ty/layout.rs:310: trailing whitespace
2019-09-09T00:56:43.0288353Z tidy error: /checkout/src/librustc_mir/interpret/place.rs:11: line longer than 100 chars
2019-09-09T00:56:43.0292472Z tidy error: /checkout/src/librustc_mir/interpret/intrinsics.rs:153: line longer than 100 chars
2019-09-09T00:56:43.0296627Z tidy error: /checkout/src/librustc_mir/interpret/memory.rs:363: trailing whitespace
2019-09-09T00:56:43.0298798Z tidy error: /checkout/src/librustc_mir/interpret/memory.rs:770: line longer than 100 chars
2019-09-09T00:56:43.0310979Z tidy error: /checkout/src/librustc_mir/interpret/operand.rs:383: line longer than 100 chars
2019-09-09T00:56:43.0311045Z tidy error: /checkout/src/librustc_mir/interpret/operand.rs:634: line longer than 100 chars
2019-09-09T00:56:43.3167692Z tidy error: /checkout/src/librustc_codegen_ssa/mir/place.rs:402: line longer than 100 chars
2019-09-09T00:56:43.3227222Z tidy error: /checkout/src/librustc_codegen_llvm/type_of.rs:5: line longer than 100 chars
2019-09-09T00:56:43.3237474Z tidy error: /checkout/src/librustc_codegen_llvm/debuginfo/metadata.rs:1921: trailing whitespace
2019-09-09T00:56:43.3255916Z tidy error: /checkout/src/librustc_codegen_llvm/abi.rs:272: line longer than 100 chars
2019-09-09T00:56:43.3597452Z tidy error: /checkout/src/librustc_passes/layout_test.rs:68: line longer than 100 chars
2019-09-09T00:56:43.3597701Z tidy error: /checkout/src/librustc_passes/layout_test.rs:74: line longer than 100 chars
2019-09-09T00:56:44.3799592Z some tidy checks failed
2019-09-09T00:56:44.3799730Z 
2019-09-09T00:56:44.3799730Z 
2019-09-09T00:56:44.3800638Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-09-09T00:56:44.3800727Z 
2019-09-09T00:56:44.3800763Z 
2019-09-09T00:56:44.3809203Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-09-09T00:56:44.3810115Z Build completed unsuccessfully in 0:01:26
2019-09-09T00:56:44.3810115Z Build completed unsuccessfully in 0:01:26
2019-09-09T00:56:44.3860047Z == clock drift check ==
2019-09-09T00:56:44.3872110Z   local time: Mon Sep  9 00:56:44 UTC 2019
2019-09-09T00:56:44.5342833Z   network time: Mon, 09 Sep 2019 00:56:44 GMT
2019-09-09T00:56:44.5348037Z == end clock drift check ==
2019-09-09T00:56:46.0303481Z ##[error]Bash exited with code '1'.
2019-09-09T00:56:46.0330991Z ##[section]Starting: Checkout
2019-09-09T00:56:46.0333025Z ==============================================================================
2019-09-09T00:56:46.0333082Z Task         : Get sources
2019-09-09T00:56:46.0333149Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-09-09T16:46:42Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-09T15:37:20.7144346Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-09T15:37:20.7352959Z ##[command]git config gc.auto 0
2019-09-09T15:37:20.7416755Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-09T15:37:20.7467698Z ##[command]git config --get-all http.proxy
2019-09-09T15:37:20.7610848Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64299/merge:refs/remotes/pull/64299/merge
---
2019-09-09T16:36:24.5385224Z .................................................................................................... 1500/9009
2019-09-09T16:36:29.9047386Z .................................................................................................... 1600/9009
2019-09-09T16:36:41.5158511Z ......................................................i...............i............................. 1700/9009
2019-09-09T16:36:48.7005277Z .................................................................................................... 1800/9009
2019-09-09T16:37:02.0165335Z .............................................iiiii.................................................. 1900/9009
2019-09-09T16:37:12.0294380Z .................................................................................................... 2100/9009
2019-09-09T16:37:14.2599421Z .................................................................................................... 2200/9009
2019-09-09T16:37:17.4965179Z .................................................................................................... 2300/9009
2019-09-09T16:37:24.8532277Z .................................................................................................... 2400/9009
---
2019-09-09T16:40:08.7790142Z ...................................i...............i................................................ 4700/9009
2019-09-09T16:40:19.4337372Z .................................................................................................... 4800/9009
2019-09-09T16:40:25.3190680Z .................................................................................................... 4900/9009
2019-09-09T16:40:35.1328601Z .................................................................................................... 5000/9009
2019-09-09T16:40:40.6831279Z .................ii.ii.............................................................................. 5100/9009
2019-09-09T16:40:50.2743348Z .................................................................................................... 5300/9009
2019-09-09T16:40:59.5456038Z ................................................................................i................... 5400/9009
2019-09-09T16:41:06.7151121Z .................................................................................................... 5500/9009
2019-09-09T16:41:12.1704564Z .................................................................................................... 5600/9009
2019-09-09T16:41:12.1704564Z .................................................................................................... 5600/9009
2019-09-09T16:41:22.0124157Z ..........................................................................ii...i..ii...........i.... 5700/9009
2019-09-09T16:41:45.1066891Z .................................................................................................... 5900/9009
2019-09-09T16:41:54.0977504Z .................................................................................................... 6000/9009
2019-09-09T16:41:54.0977504Z .................................................................................................... 6000/9009
2019-09-09T16:41:59.4946683Z ............................................................................i..ii................... 6100/9009
2019-09-09T16:42:12.6307661Z .................................................................................................... 6200/9009
2019-09-09T16:42:26.1606452Z .................................................FF..FFF..FFFFF..................................... 6300/9009
2019-09-09T16:42:29.8877727Z .................................................................................................... 6500/9009
2019-09-09T16:42:32.1635084Z .......i............................................................................................ 6600/9009
2019-09-09T16:42:36.4876030Z ..................................................................F................................. 6700/9009
2019-09-09T16:42:54.1589827Z .................................................................................................... 6800/9009
---
2019-09-09T16:46:19.8541093Z ---- [ui] ui/packed-struct/packed-struct-transmute.rs stdout ----
2019-09-09T16:46:19.8541151Z 
2019-09-09T16:46:19.8541196Z error: ui test compiled successfully!
2019-09-09T16:46:19.8541236Z status: exit code: 0
2019-09-09T16:46:19.8541939Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/packed-struct/packed-struct-transmute.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/packed-struct/packed-struct-transmute" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/packed-struct/packed-struct-transmute/auxiliary" "-A" "unused"
2019-09-09T16:46:19.8542551Z ------------------------------------------
2019-09-09T16:46:19.8542584Z 
2019-09-09T16:46:19.8542774Z ------------------------------------------
2019-09-09T16:46:19.8542816Z stderr:
---
2019-09-09T16:46:19.8543666Z ---- [ui] ui/packed-struct/packed-struct-generic-transmute.rs stdout ----
2019-09-09T16:46:19.8543697Z 
2019-09-09T16:46:19.8543737Z error: ui test compiled successfully!
2019-09-09T16:46:19.8543975Z status: exit code: 0
2019-09-09T16:46:19.8545142Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/packed-struct/packed-struct-generic-transmute.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/packed-struct/packed-struct-generic-transmute" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/packed-struct/packed-struct-generic-transmute/auxiliary" "-A" "unused"
2019-09-09T16:46:19.8546266Z ------------------------------------------
2019-09-09T16:46:19.8546307Z 
2019-09-09T16:46:19.8546578Z ------------------------------------------
2019-09-09T16:46:19.8546622Z stderr:
---
2019-09-09T16:46:19.8547392Z ---- [ui] ui/packed/packed-struct-generic-layout.rs stdout ----
2019-09-09T16:46:19.8547444Z 
2019-09-09T16:46:19.8547671Z error: test compilation failed although it shouldn't!
2019-09-09T16:46:19.8547879Z status: exit code: 1
2019-09-09T16:46:19.8548690Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/packed/packed-struct-generic-layout.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/packed/packed-struct-generic-layout/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/packed/packed-struct-generic-layout/auxiliary"
2019-09-09T16:46:19.8549024Z ------------------------------------------
2019-09-09T16:46:19.8549059Z 
2019-09-09T16:46:19.8549432Z ------------------------------------------
2019-09-09T16:46:19.8549488Z stderr:
2019-09-09T16:46:19.8549488Z stderr:
2019-09-09T16:46:19.8549677Z ------------------------------------------
2019-09-09T16:46:19.8550084Z error[E0512]: cannot transmute between types of different sizes, or dependently-sized types
2019-09-09T16:46:19.8550372Z    |
2019-09-09T16:46:19.8550372Z    |
2019-09-09T16:46:19.8550411Z LL |         let transd : [u8; 9] = mem::transmute(s);
2019-09-09T16:46:19.8550509Z    |
2019-09-09T16:46:19.8550509Z    |
2019-09-09T16:46:19.8550549Z    = note: source type: `S<u32, i32>` (96 bits)
2019-09-09T16:46:19.8550590Z    = note: target type: `[u8; 9]` (72 bits)
2019-09-09T16:46:19.8550672Z error: aborting due to previous error
2019-09-09T16:46:19.8550789Z 
2019-09-09T16:46:19.8551026Z For more information about this error, try `rustc --explain E0512`.
2019-09-09T16:46:19.8551076Z 
2019-09-09T16:46:19.8551076Z 
2019-09-09T16:46:19.8551264Z ------------------------------------------
2019-09-09T16:46:19.8551454Z 
2019-09-09T16:46:19.8551477Z 
2019-09-09T16:46:19.8551848Z ---- [ui] ui/packed/packed-struct-layout.rs stdout ----
2019-09-09T16:46:19.8551877Z 
2019-09-09T16:46:19.8552059Z error: test compilation failed although it shouldn't!
2019-09-09T16:46:19.8552098Z status: exit code: 1
2019-09-09T16:46:19.8552696Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/packed/packed-struct-layout.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/packed/packed-struct-layout/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/packed/packed-struct-layout/auxiliary"
2019-09-09T16:46:19.8552967Z ------------------------------------------
2019-09-09T16:46:19.8552993Z 
2019-09-09T16:46:19.8553168Z ------------------------------------------
2019-09-09T16:46:19.8553220Z stderr:
2019-09-09T16:46:19.8553220Z stderr:
2019-09-09T16:46:19.8553561Z ------------------------------------------
2019-09-09T16:46:19.8553775Z error[E0512]: cannot transmute between types of different sizes, or dependently-sized types
2019-09-09T16:46:19.8554028Z    |
2019-09-09T16:46:19.8554028Z    |
2019-09-09T16:46:19.8554064Z LL |         let transd : [u8; 5] = mem::transmute(s5);
2019-09-09T16:46:19.8554151Z    |
2019-09-09T16:46:19.8554151Z    |
2019-09-09T16:46:19.8554185Z    = note: source type: `S5` (64 bits)
2019-09-09T16:46:19.8554239Z    = note: target type: `[u8; 5]` (40 bits)
2019-09-09T16:46:19.8554304Z error: aborting due to previous error
2019-09-09T16:46:19.8554327Z 
2019-09-09T16:46:19.8554520Z For more information about this error, try `rustc --explain E0512`.
2019-09-09T16:46:19.8554562Z 
---
2019-09-09T16:46:19.8563254Z ---- [ui] ui/packed/packed-tuple-struct-layout.rs stdout ----
2019-09-09T16:46:19.8563298Z 
2019-09-09T16:46:19.8563476Z error: test compilation failed although it shouldn't!
2019-09-09T16:46:19.8563521Z status: exit code: 1
2019-09-09T16:46:19.8564189Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/packed/packed-tuple-struct-layout.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/packed/packed-tuple-struct-layout/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/packed/packed-tuple-struct-layout/auxiliary"
2019-09-09T16:46:19.8564485Z ------------------------------------------
2019-09-09T16:46:19.8564512Z 
2019-09-09T16:46:19.8564685Z ------------------------------------------
2019-09-09T16:46:19.8564721Z stderr:
2019-09-09T16:46:19.8564721Z stderr:
2019-09-09T16:46:19.8564903Z ------------------------------------------
2019-09-09T16:46:19.8565112Z error[E0512]: cannot transmute between types of different sizes, or dependently-sized types
2019-09-09T16:46:19.8565376Z    |
2019-09-09T16:46:19.8565376Z    |
2019-09-09T16:46:19.8565413Z LL |         let transd : [u8; 5] = mem::transmute(s5);
2019-09-09T16:46:19.8565511Z    |
2019-09-09T16:46:19.8565511Z    |
2019-09-09T16:46:19.8565545Z    = note: source type: `S5` (64 bits)
2019-09-09T16:46:19.8565582Z    = note: target type: `[u8; 5]` (40 bits)
2019-09-09T16:46:19.8565657Z error: aborting due to previous error
2019-09-09T16:46:19.8565680Z 
2019-09-09T16:46:19.8565874Z For more information about this error, try `rustc --explain E0512`.
2019-09-09T16:46:19.8565900Z 
---
2019-09-09T16:46:19.8571677Z 
2019-09-09T16:46:19.8571863Z ---- [ui] ui/print_type_sizes/packed.rs stdout ----
2019-09-09T16:46:19.8571903Z diff of stdout:
2019-09-09T16:46:19.8571926Z 
2019-09-09T16:46:19.8572213Z - print-type-size type: `Packed2C`: 12 bytes, alignment: 2 bytes
2019-09-09T16:46:19.8572455Z + print-type-size type: `Packed2C`: 14 bytes, alignment: 2 bytes
2019-09-09T16:46:19.8572640Z 2 print-type-size     field `.a`: 1 bytes
2019-09-09T16:46:19.8572837Z 3 print-type-size     field `.b`: 1 bytes
2019-09-09T16:46:19.8573019Z 4 print-type-size     field `.g`: 4 bytes
2019-09-09T16:46:19.8573223Z + print-type-size     padding: 2 bytes
2019-09-09T16:46:19.8573223Z + print-type-size     padding: 2 bytes
2019-09-09T16:46:19.8573420Z 5 print-type-size     field `.c`: 1 bytes
2019-09-09T16:46:19.8573598Z 6 print-type-size     padding: 1 bytes
2019-09-09T16:46:19.8573787Z 7 print-type-size     field `.h`: 2 bytes
2019-09-09T16:46:19.8573814Z 
2019-09-09T16:46:19.8574006Z 8 print-type-size     field `.d`: 1 bytes
2019-09-09T16:46:19.8574186Z 9 print-type-size     end padding: 1 bytes
2019-09-09T16:46:19.8574384Z - print-type-size type: `Padded`: 12 bytes, alignment: 4 bytes
2019-09-09T16:46:19.8574590Z - print-type-size     field `.g`: 4 bytes
2019-09-09T16:46:19.8574773Z - print-type-size     field `.h`: 2 bytes
2019-09-09T16:46:19.8575131Z + print-type-size type: `Packed1`: 13 bytes, alignment: 1 bytes
2019-09-09T16:46:19.8575320Z 13 print-type-size     field `.a`: 1 bytes
2019-09-09T16:46:19.8575492Z 14 print-type-size     field `.b`: 1 bytes
2019-09-09T16:46:19.8575662Z + print-type-size     field `.g`: 4 bytes
2019-09-09T16:46:19.8575847Z + print-type-size     padding: 2 bytes
2019-09-09T16:46:19.8576020Z 15 print-type-size     field `.c`: 1 bytes
2019-09-09T16:46:19.8576656Z + print-type-size     field `.h`: 2 bytes
2019-09-09T16:46:19.8576928Z + print-type-size     padding: 1 bytes
2019-09-09T16:46:19.8577558Z 16 print-type-size     field `.d`: 1 bytes
2019-09-09T16:46:19.8577775Z - print-type-size     end padding: 2 bytes
2019-09-09T16:46:19.8578010Z - print-type-size type: `Packed1`: 10 bytes, alignment: 1 bytes
2019-09-09T16:46:19.8578268Z + print-type-size type: `Padded`: 12 bytes, alignment: 4 bytes
2019-09-09T16:46:19.8578493Z + print-type-size     field `.g`: 4 bytes
2019-09-09T16:46:19.8578712Z + print-type-size     field `.h`: 2 bytes
2019-09-09T16:46:19.8578948Z 19 print-type-size     field `.a`: 1 bytes
2019-09-09T16:46:19.8579164Z 20 print-type-size     field `.b`: 1 bytes
2019-09-09T16:46:19.8579378Z - print-type-size     field `.g`: 4 bytes
2019-09-09T16:46:19.8579610Z 22 print-type-size     field `.c`: 1 bytes
2019-09-09T16:46:19.8579992Z - print-type-size     field `.h`: 2 bytes
2019-09-09T16:46:19.8580173Z 24 print-type-size     field `.d`: 1 bytes
2019-09-09T16:46:19.8580371Z + print-type-size     end padding: 2 bytes
2019-09-09T16:46:19.8580575Z 25 print-type-size type: `Packed2`: 10 bytes, alignment: 2 bytes
2019-09-09T16:46:19.8580768Z 26 print-type-size     field `.g`: 4 bytes
2019-09-09T16:46:19.8580949Z 27 print-type-size     field `.h`: 2 bytes
2019-09-09T16:46:19.8581013Z 
2019-09-09T16:46:19.8581052Z The actual stdout differed from the expected stdout.
2019-09-09T16:46:19.8581626Z Actual stdout saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/packed/packed.stdout
2019-09-09T16:46:19.8581626Z Actual stdout saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/packed/packed.stdout
2019-09-09T16:46:19.8581841Z To update references, rerun the tests and pass the `--bless` flag
2019-09-09T16:46:19.8582105Z To only update this specific test, also pass `--test-args print_type_sizes/packed.rs`
2019-09-09T16:46:19.8582183Z error: 1 errors occurred comparing output.
2019-09-09T16:46:19.8582218Z status: exit code: 0
2019-09-09T16:46:19.8582218Z status: exit code: 0
2019-09-09T16:46:19.8582887Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/print_type_sizes/packed.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/packed" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "print-type-sizes" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/print_type_sizes/packed/auxiliary" "-A" "unused"
2019-09-09T16:46:19.8583194Z ------------------------------------------
2019-09-09T16:46:19.8583194Z ------------------------------------------
2019-09-09T16:46:19.8583402Z print-type-size type: `Packed2C`: 14 bytes, alignment: 2 bytes
2019-09-09T16:46:19.8583579Z print-type-size     field `.a`: 1 bytes
2019-09-09T16:46:19.8583766Z print-type-size     field `.b`: 1 bytes
2019-09-09T16:46:19.8583939Z print-type-size     field `.g`: 4 bytes
2019-09-09T16:46:19.8584109Z print-type-size     padding: 2 bytes
2019-09-09T16:46:19.8584282Z print-type-size     field `.c`: 1 bytes
2019-09-09T16:46:19.8584469Z print-type-size     padding: 1 bytes
2019-09-09T16:46:19.8584648Z print-type-size     field `.h`: 2 bytes
2019-09-09T16:46:19.8584816Z print-type-size     field `.d`: 1 bytes
2019-09-09T16:46:19.8585011Z print-type-size     end padding: 1 bytes
2019-09-09T16:46:19.8585201Z print-type-size type: `Packed1`: 13 bytes, alignment: 1 bytes
2019-09-09T16:46:19.8585551Z print-type-size     field `.a`: 1 bytes
2019-09-09T16:46:19.8585743Z print-type-size     field `.b`: 1 bytes
2019-09-09T16:46:19.8586118Z print-type-size     field `.g`: 4 bytes
2019-09-09T16:46:19.8586933Z print-type-size     padding: 2 bytes
2019-09-09T16:46:19.8587178Z print-type-size     field `.c`: 1 bytes
2019-09-09T16:46:19.8587391Z print-type-size     field `.h`: 2 bytes
2019-09-09T16:46:19.8587600Z print-type-size     padding: 1 bytes
2019-09-09T16:46:19.8587811Z print-type-size     field `.d`: 1 bytes
2019-09-09T16:46:19.8588063Z print-type-size type: `Padded`: 12 bytes, alignment: 4 bytes
2019-09-09T16:46:19.8588281Z print-type-size     field `.g`: 4 bytes
2019-09-09T16:46:19.8588653Z print-type-size     field `.h`: 2 bytes
2019-09-09T16:46:19.8588883Z print-type-size     field `.a`: 1 bytes
2019-09-09T16:46:19.8589093Z print-type-size     field `.b`: 1 bytes
2019-09-09T16:46:19.8595726Z print-type-size     field `.c`: 1 bytes
2019-09-09T16:46:19.8601095Z print-type-size     field `.d`: 1 bytes
2019-09-09T16:46:19.8604272Z print-type-size     end padding: 2 bytes
2019-09-09T16:46:19.8604512Z print-type-size type: `Packed2`: 10 bytes, alignment: 2 bytes
2019-09-09T16:46:19.8604720Z print-type-size     field `.g`: 4 bytes
2019-09-09T16:46:19.8604902Z print-type-size     field `.h`: 2 bytes
2019-09-09T16:46:19.8605239Z print-type-size     field `.a`: 1 bytes
2019-09-09T16:46:19.8605430Z print-type-size     field `.b`: 1 bytes
2019-09-09T16:46:19.8605607Z print-type-size     field `.c`: 1 bytes
2019-09-09T16:46:19.8605779Z print-type-size     field `.d`: 1 bytes
2019-09-09T16:46:19.8606000Z ------------------------------------------
2019-09-09T16:46:19.8606048Z stderr:
2019-09-09T16:46:19.8606680Z ------------------------------------------
2019-09-09T16:46:19.8606722Z 
2019-09-09T16:46:19.8606722Z 
2019-09-09T16:46:19.8606956Z ------------------------------------------
2019-09-09T16:46:19.8606988Z 
2019-09-09T16:46:19.8607014Z 
2019-09-09T16:46:19.8607273Z ---- [ui] ui/rfc-2126-extern-absolute-paths/non-existent-3.rs stdout ----
2019-09-09T16:46:19.8607326Z 
2019-09-09T16:46:19.8607375Z error: Error: expected failure status (Some(1)) but received status None.
2019-09-09T16:46:19.8607422Z status: signal: 11
2019-09-09T16:46:19.8608247Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2126-extern-absolute-paths/non-existent-3.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-extern-absolute-paths/non-existent-3" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-extern-absolute-paths/non-existent-3/auxiliary" "-A" "unused"
2019-09-09T16:46:19.8608591Z ------------------------------------------
2019-09-09T16:46:19.8608625Z 
2019-09-09T16:46:19.8609022Z ------------------------------------------
2019-09-09T16:46:19.8609106Z stderr:
2019-09-09T16:46:19.8609106Z stderr:
2019-09-09T16:46:19.8609364Z ------------------------------------------
2019-09-09T16:46:19.8609395Z 
2019-09-09T16:46:19.8609764Z ------------------------------------------
2019-09-09T16:46:19.8609788Z 
2019-09-09T16:46:19.8609824Z 
2019-09-09T16:46:19.8610021Z ---- [ui] ui/rfc-2126-extern-absolute-paths/not-whitelisted.rs stdout ----
2019-09-09T16:46:19.8610051Z 
2019-09-09T16:46:19.8610108Z error: Error: expected failure status (Some(1)) but received status None.
2019-09-09T16:46:19.8610146Z status: signal: 11
2019-09-09T16:46:19.8610796Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2126-extern-absolute-paths/not-whitelisted.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-extern-absolute-paths/not-whitelisted" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-extern-absolute-paths/not-whitelisted/auxiliary" "-A" "unused"
2019-09-09T16:46:19.8611077Z ------------------------------------------
2019-09-09T16:46:19.8611119Z 
2019-09-09T16:46:19.8611291Z ------------------------------------------
2019-09-09T16:46:19.8611326Z stderr:
---
2019-09-09T16:46:19.8613810Z 
2019-09-09T16:46:19.8613832Z 
2019-09-09T16:46:19.8614002Z ---- [ui] ui/use/use-keyword.rs stdout ----
2019-09-09T16:46:19.8614034Z 
2019-09-09T16:46:19.8614071Z error: Error: expected failure status (Some(1)) but received status None.
2019-09-09T16:46:19.8614123Z status: signal: 11
2019-09-09T16:46:19.8614675Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/use/use-keyword.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/use/use-keyword" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/use/use-keyword/auxiliary" "-A" "unused"
2019-09-09T16:46:19.8614939Z ------------------------------------------
2019-09-09T16:46:19.8614966Z 
2019-09-09T16:46:19.8615151Z ------------------------------------------
2019-09-09T16:46:19.8615186Z stderr:
2019-09-09T16:46:19.8615186Z stderr:
2019-09-09T16:46:19.8615426Z ------------------------------------------
2019-09-09T16:46:19.8615498Z error[E0429]: `self` imports are only allowed within a { } list
2019-09-09T16:46:19.8615751Z    |
2019-09-09T16:46:19.8615801Z LL |         use self as A;
2019-09-09T16:46:19.8615838Z    |             ^^^^^^^^^
2019-09-09T16:46:19.8615860Z 
2019-09-09T16:46:19.8615860Z 
2019-09-09T16:46:19.8615880Z 
2019-09-09T16:46:19.8616069Z ------------------------------------------
2019-09-09T16:46:19.8616094Z 
2019-09-09T16:46:19.8616114Z 
2019-09-09T16:46:19.8616633Z ---- [ui] ui/use/use-mod/use-mod-2.rs stdout ----
2019-09-09T16:46:19.8616679Z 
2019-09-09T16:46:19.8616760Z error: Error: expected failure status (Some(1)) but received status None.
2019-09-09T16:46:19.8616806Z status: signal: 11
2019-09-09T16:46:19.8624293Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/use/use-mod/use-mod-2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/use/use-mod/use-mod-2" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/use/use-mod/use-mod-2/auxiliary" "-A" "unused"
2019-09-09T16:46:19.8624625Z ------------------------------------------
2019-09-09T16:46:19.8624854Z 
2019-09-09T16:46:19.8625038Z ------------------------------------------
2019-09-09T16:46:19.8625255Z stderr:
---
2019-09-09T16:46:19.8631464Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-09T16:46:19.8631691Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-09T16:46:19.8631736Z 
2019-09-09T16:46:19.8631758Z 
2019-09-09T16:46:19.8633732Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-09T16:46:19.8634013Z 
2019-09-09T16:46:19.8634042Z 
2019-09-09T16:46:19.8634096Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-09T16:46:19.8634162Z Build completed unsuccessfully in 1:01:56
2019-09-09T16:46:19.8634162Z Build completed unsuccessfully in 1:01:56
2019-09-09T16:46:19.8707718Z == clock drift check ==
2019-09-09T16:46:19.8723125Z   local time: Mon Sep  9 16:46:19 UTC 2019
2019-09-09T16:46:20.0307115Z   network time: Mon, 09 Sep 2019 16:46:20 GMT
2019-09-09T16:46:20.0313063Z == end clock drift check ==
2019-09-09T16:46:20.9281572Z ##[error]Bash exited with code '1'.
2019-09-09T16:46:20.9342221Z ##[section]Starting: Checkout
2019-09-09T16:46:20.9343897Z ==============================================================================
2019-09-09T16:46:20.9344113Z Task         : Get sources
2019-09-09T16:46:20.9344173Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

estebank · 2019-09-09T18:01:07Z

This doesn't seem like something I should be reviewing.

r? @oli-obk

I think you have better context for this?

Dante-Broggi · 2019-09-09T21:39:06Z

I think I found what I changed to cause those issues regarding packed, and will now fix it, but the others I have no ideas about at the moment.

rust-highfive · 2019-09-09T23:53:22Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-09T22:38:43.6187493Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-09T22:38:43.6416237Z ##[command]git config gc.auto 0
2019-09-09T22:38:43.6507174Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-09T22:38:43.6564312Z ##[command]git config --get-all http.proxy
2019-09-09T22:38:43.6747041Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64299/merge:refs/remotes/pull/64299/merge
---
2019-09-09T23:41:59.0466570Z .................................................................................................... 1500/9006
2019-09-09T23:42:05.1320798Z .................................................................................................... 1600/9006
2019-09-09T23:42:18.1398914Z .......................................................i...............i............................ 1700/9006
2019-09-09T23:42:26.0407265Z .................................................................................................... 1800/9006
2019-09-09T23:42:40.9467305Z ..............................................iiiii................................................. 1900/9006
2019-09-09T23:42:52.3138357Z .................................................................................................... 2100/9006
2019-09-09T23:42:54.9772052Z .................................................................................................... 2200/9006
2019-09-09T23:42:58.9724755Z .................................................................................................... 2300/9006
2019-09-09T23:43:06.9832823Z .................................................................................................... 2400/9006
---
2019-09-09T23:46:09.9044297Z .................................i...............i.................................................. 4700/9006
2019-09-09T23:46:21.8585394Z .................................................................................................... 4800/9006
2019-09-09T23:46:28.2480012Z .................................................................................................... 4900/9006
2019-09-09T23:46:39.3340154Z .................................................................................................... 5000/9006
2019-09-09T23:46:45.5880893Z ................ii.ii............................................................................... 5100/9006
2019-09-09T23:46:56.6057359Z .................................................................................................... 5300/9006
2019-09-09T23:47:06.9517719Z ...............................................................................i.................... 5400/9006
2019-09-09T23:47:14.9702489Z .................................................................................................... 5500/9006
2019-09-09T23:47:21.2330030Z .................................................................................................... 5600/9006
2019-09-09T23:47:21.2330030Z .................................................................................................... 5600/9006
2019-09-09T23:47:32.1000516Z .........................................................................ii...i..ii...........i..... 5700/9006
2019-09-09T23:47:57.6708165Z .................................................................................................... 5900/9006
2019-09-09T23:48:07.5377322Z .................................................................................................... 6000/9006
2019-09-09T23:48:07.5377322Z .................................................................................................... 6000/9006
2019-09-09T23:48:13.1010021Z ...........................................................................i..ii.................... 6100/9006
2019-09-09T23:48:43.4449925Z .................................................................................................... 6300/9006
2019-09-09T23:48:45.6141180Z ..................................i................................................................. 6400/9006
2019-09-09T23:48:47.8830068Z .................................................................................................... 6500/9006
2019-09-09T23:48:50.5840312Z ......i............................................................................................. 6600/9006
---
2019-09-09T23:52:59.3688372Z failures:
2019-09-09T23:52:59.3708857Z 
2019-09-09T23:52:59.3709442Z ---- [ui] ui/rfc-2126-extern-absolute-paths/non-existent-3.rs stdout ----
2019-09-09T23:52:59.3709522Z 
2019-09-09T23:52:59.3709607Z error: Error: expected failure status (Some(1)) but received status None.
2019-09-09T23:52:59.3709662Z status: signal: 11
2019-09-09T23:52:59.3710611Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2126-extern-absolute-paths/non-existent-3.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-extern-absolute-paths/non-existent-3" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-extern-absolute-paths/non-existent-3/auxiliary" "-A" "unused"
2019-09-09T23:52:59.3711002Z ------------------------------------------
2019-09-09T23:52:59.3711302Z 
2019-09-09T23:52:59.3711607Z ------------------------------------------
2019-09-09T23:52:59.3711659Z stderr:
2019-09-09T23:52:59.3711659Z stderr:
2019-09-09T23:52:59.3711916Z ------------------------------------------
2019-09-09T23:52:59.3711951Z 
2019-09-09T23:52:59.3712190Z ------------------------------------------
2019-09-09T23:52:59.3712224Z 
2019-09-09T23:52:59.3712251Z 
2019-09-09T23:52:59.3712549Z ---- [ui] ui/rfc-2126-extern-absolute-paths/not-whitelisted.rs stdout ----
2019-09-09T23:52:59.3712588Z 
2019-09-09T23:52:59.3712656Z error: Error: expected failure status (Some(1)) but received status None.
2019-09-09T23:52:59.3712726Z status: signal: 11
2019-09-09T23:52:59.3713952Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/rfc-2126-extern-absolute-paths/not-whitelisted.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-extern-absolute-paths/not-whitelisted" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/rfc-2126-extern-absolute-paths/not-whitelisted/auxiliary" "-A" "unused"
2019-09-09T23:52:59.3714422Z ------------------------------------------
2019-09-09T23:52:59.3714459Z 
2019-09-09T23:52:59.3714725Z ------------------------------------------
2019-09-09T23:52:59.3714953Z stderr:
2019-09-09T23:52:59.3714953Z stderr:
2019-09-09T23:52:59.3715247Z ------------------------------------------
2019-09-09T23:52:59.3715282Z 
2019-09-09T23:52:59.3715540Z ------------------------------------------
2019-09-09T23:52:59.3715573Z 
2019-09-09T23:52:59.3715601Z 
2019-09-09T23:52:59.3715837Z ---- [ui] ui/use/use-keyword.rs stdout ----
2019-09-09T23:52:59.3715888Z 
2019-09-09T23:52:59.3715942Z error: Error: expected failure status (Some(1)) but received status None.
2019-09-09T23:52:59.3716008Z status: signal: 11
2019-09-09T23:52:59.3716817Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/use/use-keyword.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/use/use-keyword" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/use/use-keyword/auxiliary" "-A" "unused"
2019-09-09T23:52:59.3717174Z ------------------------------------------
2019-09-09T23:52:59.3717210Z 
2019-09-09T23:52:59.3717448Z ------------------------------------------
2019-09-09T23:52:59.3717497Z stderr:
2019-09-09T23:52:59.3717497Z stderr:
2019-09-09T23:52:59.3717750Z ------------------------------------------
2019-09-09T23:52:59.3717806Z error[E0429]: `self` imports are only allowed within a { } list
2019-09-09T23:52:59.3718157Z    |
2019-09-09T23:52:59.3718205Z LL |         use self as A;
2019-09-09T23:52:59.3718254Z    |             ^^^^^^^^^
2019-09-09T23:52:59.3718300Z 
2019-09-09T23:52:59.3718300Z 
2019-09-09T23:52:59.3718329Z 
2019-09-09T23:52:59.3718569Z ------------------------------------------
2019-09-09T23:52:59.3718604Z 
2019-09-09T23:52:59.3718632Z 
2019-09-09T23:52:59.3718895Z ---- [ui] ui/use/use-mod/use-mod-2.rs stdout ----
2019-09-09T23:52:59.3718929Z 
2019-09-09T23:52:59.3718991Z error: Error: expected failure status (Some(1)) but received status None.
2019-09-09T23:52:59.3719060Z status: signal: 11
2019-09-09T23:52:59.3719866Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/use/use-mod/use-mod-2.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/use/use-mod/use-mod-2" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/use/use-mod/use-mod-2/auxiliary" "-A" "unused"
2019-09-09T23:52:59.3720394Z ------------------------------------------
2019-09-09T23:52:59.3720430Z 
2019-09-09T23:52:59.3720672Z ------------------------------------------
2019-09-09T23:52:59.3720739Z stderr:
---
2019-09-09T23:52:59.3766980Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:536:22
2019-09-09T23:52:59.3767083Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-09-09T23:52:59.3783824Z 
2019-09-09T23:52:59.3784131Z 
2019-09-09T23:52:59.3785987Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-09-09T23:52:59.3790328Z 
2019-09-09T23:52:59.3790362Z 
2019-09-09T23:52:59.3790459Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-09-09T23:52:59.3790551Z Build completed unsuccessfully in 1:07:04
2019-09-09T23:52:59.3790551Z Build completed unsuccessfully in 1:07:04
2019-09-09T23:52:59.3848187Z == clock drift check ==
2019-09-09T23:52:59.3865369Z   local time: Mon Sep  9 23:52:59 UTC 2019
2019-09-09T23:52:59.5233784Z   network time: Mon, 09 Sep 2019 23:52:59 GMT
2019-09-09T23:52:59.5239893Z == end clock drift check ==
2019-09-09T23:53:00.3532355Z ##[error]Bash exited with code '1'.
2019-09-09T23:53:00.3593144Z ##[section]Starting: Checkout
2019-09-09T23:53:00.3595597Z ==============================================================================
2019-09-09T23:53:00.3595678Z Task         : Get sources
2019-09-09T23:53:00.3595730Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-09-14T19:05:49Z

☔ The latest upstream changes (presumably #64456) made this pull request unmergeable. Please resolve the merge conflicts.

src/librustc/mir/interpret/allocation.rs

oli-obk · 2019-09-20T08:23:10Z

So I did a first shallow review, the general idea looks good to me.

Wrt the test failures, I think the best way to figure out what causes them is to bisect your own PR. So take the middle commit, see if that passes tests, if it does, take the commit between the currently working commit and the last commit. Repeat until failure.

Once you know which commit causes the failure, it will be much simpler to figure out the problem.

Dante-Broggi · 2019-09-20T23:50:15Z

Commenting this for the record: git bisect shows the first bad commit is LayoutDetails.pref_pos
However, the failure was different on my mac (laptop) than on the Linux CI. Specifically, 99% (~50/9009) of the (ui?) tests all fail with:

thread 'rustc' panicked at 'assertion failed: `(left == right)`
  left: `8`,
 right: `0`', /Users/dantebroggi/.cargo/registry/src/github.com-1ecc6299db9ec823/hashbrown-0.5.0/src/raw/mod.rs:1086:9

I, still, have no idea what's causing this, the failure in CI, or why they are different.

bjorn3

I spotted two cases of different behaviour, which may explain the problem.

src/librustc/ty/layout.rs

Dante-Broggi · 2019-09-22T00:36:06Z

So those changes weren't the cause of the local failures, but I did a rebase and finished up changing Allocation, so I am going to push the changes again.

oli-obk · 2019-09-22T10:40:58Z

Huh... you can test master without failures though, right?

Dante-Broggi · 2019-09-22T18:10:29Z

On master the only failure is "---- [codegen] codegen/issue-44056-macos-tls-align.rs stdout ----"

bors · 2019-09-26T08:49:13Z

☔ The latest upstream changes (presumably #64513) made this pull request unmergeable. Please resolve the merge conflicts.

Dante-Broggi · 2019-09-28T03:09:41Z

So, I haven't found out what's causing the local failures, but I did do a full re-clone of this PR branch into a new directory, and in the new clone the only failures are "[debuginfo-gdb+lldb] debuginfo/*" tests.

Therefore the "ui/*" local failures (which still occur in the original clone) are all due to peculiarities in my clone.

bors · 2019-09-28T07:33:43Z

☔ The latest upstream changes (presumably #64864) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2019-09-28T19:52:52Z

☔ The latest upstream changes (presumably #64419) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2019-09-30T02:11:38Z

☔ The latest upstream changes (presumably #64673) made this pull request unmergeable. Please resolve the merge conflicts.

…m_vtable

oli-obk · 2019-11-12T23:40:31Z

Hi @Dante-Broggi I am unsure how to proceed here. Even if we do this refactoring we are no step closer to the swift repr or to separating stride from size, because it would break all unsafe code relying on the current scheme.

Without first resolving the language/stability I do not believe we can merge this PR or any other moving in this direction

bors · 2019-11-13T00:44:11Z

☔ The latest upstream changes (presumably #60026) made this pull request unmergeable. Please resolve the merge conflicts.

JohnCSimon · 2019-11-16T19:53:38Z

Ping from triage:
@oli-obk Do you think this PR should be marked as blocked?
cc: @Dante-Broggi @bjorn3
Thanks.

Dylan-DPC-zz · 2019-11-24T08:43:14Z

Marking this as blocked.

Dylan-DPC-zz · 2020-03-24T01:19:00Z

Given the fact this is blocked from long time and based on the comment #64299, it will take a while and the conflicts have accumulated enough to make this a mess when ready. Hence closing this and we can restart it later when ready if possible as it would be easier than rebasing this. Thanks for contributing :)

rust-highfive assigned estebank Sep 9, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2019

Dante-Broggi force-pushed the memory-position branch from 6520170 to ed66767 Compare September 9, 2019 15:36

rust-highfive assigned oli-obk and unassigned estebank Sep 9, 2019

Dante-Broggi force-pushed the memory-position branch from ed66767 to 6392f3a Compare September 9, 2019 22:38

oli-obk reviewed Sep 20, 2019

View reviewed changes

src/librustc/mir/interpret/allocation.rs Outdated Show resolved Hide resolved

bjorn3 requested changes Sep 21, 2019

View reviewed changes

src/librustc/ty/layout.rs Outdated Show resolved Hide resolved

src/librustc/ty/layout.rs Outdated Show resolved Hide resolved

Dante-Broggi force-pushed the memory-position branch from 6392f3a to b33f045 Compare September 22, 2019 00:56

Dante-Broggi force-pushed the memory-position branch 2 times, most recently from 8270ea4 to 322df44 Compare September 27, 2019 01:01

Dante-Broggi force-pushed the memory-position branch from 322df44 to 4779637 Compare September 28, 2019 14:15

Dante-Broggi force-pushed the memory-position branch from 4779637 to 4b61893 Compare September 28, 2019 21:57

Dante-Broggi added 17 commits November 12, 2019 09:54

StructKind::Prefixed

f16f182

small refactor

ae85682

InterpCx::size_and_align_of to InterpCx::mem_pos_of

7b08855

MemberDescription

72e98c0

CodegenCx.size_and_align_of to CodegenCx.mem_pos_of

2e93c0b

Mem.[re||de]allocate

adb4c83

alloc.undef

2d7d90a

error IncorrectAllocationInformation

7996f37

add Allocation::mem_pos

b1926e7

Memory::dead_alloc_map

7c41628

Mem.check_ptr_access

6ad2bed

InterpCx.read_size_and_align_from_vtable to InterpCx.read_mem_pos_fro…

ff7855a

…m_vtable

code_stats.record_type_size

fac9cf8

va_arg.emit_direct_ptr_va_arg

ef024e1

Layout.PointeeInfo

6c3e762

minor refactor

b0c72aa

ensure size_of matches its docs

10946b7

Dante-Broggi force-pushed the memory-position branch from b9e889b to 10946b7 Compare November 12, 2019 18:09

Dylan-DPC-zz added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 24, 2019

Dylan-DPC-zz closed this Mar 24, 2020

Dylan-DPC-zz added S-blocked-closed and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Mar 24, 2020

jyn514 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-blocked-closed labels Mar 10, 2021

Create compilation target versions of ::alloc::Layout #64299

Create compilation target versions of ::alloc::Layout #64299

Uh oh!

Conversation

Dante-Broggi commented Sep 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Sep 9, 2019

Uh oh!

rust-highfive commented Sep 9, 2019

Uh oh!

rust-highfive commented Sep 9, 2019

Uh oh!

estebank commented Sep 9, 2019

Uh oh!

Dante-Broggi commented Sep 9, 2019

Uh oh!

rust-highfive commented Sep 9, 2019

Uh oh!

bors commented Sep 14, 2019

Uh oh!

Uh oh!

oli-obk commented Sep 20, 2019

Uh oh!

Dante-Broggi commented Sep 20, 2019

Uh oh!

bjorn3 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Dante-Broggi commented Sep 22, 2019

Uh oh!

oli-obk commented Sep 22, 2019

Uh oh!

Dante-Broggi commented Sep 22, 2019

Uh oh!

bors commented Sep 26, 2019

Uh oh!

Dante-Broggi commented Sep 28, 2019

Uh oh!

bors commented Sep 28, 2019

Uh oh!

bors commented Sep 28, 2019

Uh oh!

bors commented Sep 30, 2019

Uh oh!

oli-obk commented Nov 12, 2019

Uh oh!

bors commented Nov 13, 2019

Uh oh!

JohnCSimon commented Nov 16, 2019

Uh oh!

Dylan-DPC-zz commented Nov 24, 2019

Uh oh!

Dylan-DPC-zz commented Mar 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Create compilation target versions of `::alloc::Layout` #64299

Create compilation target versions of `::alloc::Layout` #64299

Dante-Broggi commented Sep 9, 2019 •

edited

Loading