Skip to content

Conversation

tmandry
Copy link
Member

@tmandry tmandry commented Mar 24, 2020

Closes #66312. This issue was fixed by #68884.

r? @Zoxc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 24, 2020
@Centril
Copy link
Contributor

Centril commented Mar 24, 2020

r? @Centril @bors r+

@bors
Copy link
Collaborator

bors commented Mar 24, 2020

📌 Commit 1a21c28 has been approved by Centril

@rust-highfive rust-highfive assigned Centril and unassigned Zoxc Mar 24, 2020
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 24, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 25, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 25, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 25, 2020
Rollup of 7 pull requests

Successful merges:

 - rust-lang#70331 (Increase verbosity when using update syntax with private fields)
 - rust-lang#70349 (move `hir_id_validation` to `rustc_passes` + simplify `hir::map` code)
 - rust-lang#70361 (Update backtrace crate to 0.3.46)
 - rust-lang#70364 (resolve: Remove `rustc_attrs` as a standalone feature gate)
 - rust-lang#70369 (Fix smaller issues with invalid placeholder type errors)
 - rust-lang#70373 (normalize some imports & prefer direct ones)
 - rust-lang#70376 (Add test for rust-lang#66312)

Failed merges:

r? @ghost
@bors bors merged commit 83fc855 into rust-lang:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async fn presence affects an unrelated error message
5 participants