Skip to content

Enable function sections with windows-gnu #75604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Enable function sections with windows-gnu #75604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c97ddf
Enable function sections on windows-gnu
mati865 Aug 16, 2020
b655027
Stable-symbol-names test: compare only global symbols
mati865 Aug 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/librustc_target/spec/windows_gnu_base.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,6 @@ pub fn opts() -> TargetOptions {
);

TargetOptions {
// FIXME(#13846) this should be enabled for windows
function_sections: false,
linker: Some("gcc".to_string()),
dynamic_linking: true,
executables: true,
Expand Down
2 changes: 1 addition & 1 deletion src/test/run-make-fulldeps/stable-symbol-names/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
# 4. sort those symbol names for deterministic comparison
# 5. write the result into a file

dump-symbols = nm "$(TMPDIR)/lib$(1).rlib" \
dump-symbols = nm -g "$(TMPDIR)/lib$(1).rlib" \
| grep -E "$(2)" \
| sed -E "s/.*(_ZN.*E|_R[a-zA-Z0-9_]*).*/\1/" \
| sort \
Expand Down