Trait upcasting coercion (part1) #86264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
crlf0710
force-pushed
the
trait_upcasting_part1
branch
from
af39d0f to
4965666
Compare
Contributor
|
r? @nikomatsakis to clarify on #60900 (comment) |
21 tasks
compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs
Outdated
Show resolved
Hide resolved
compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs
Outdated
Show resolved
Hide resolved
crlf0710
force-pushed
the
trait_upcasting_part1
branch
from
4965666 to
c2c6bb7
Compare
This comment has been minimized.
This comment has been minimized.
crlf0710
force-pushed
the
trait_upcasting_part1
branch
from
c2c6bb7 to
2f0db91
Compare
crlf0710
added
S-waiting-on-author
Collaborator
|
☔ The latest upstream changes (presumably #86446) made this pull request unmergeable. Please resolve the merge conflicts. |
crlf0710
force-pushed
the
trait_upcasting_part1
branch
from
2f0db91 to
4b7453d
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
I'd like this to wait on #86461 first. |
crlf0710
added
S-blocked
Collaborator
|
☔ The latest upstream changes (presumably #83898) made this pull request unmergeable. Please resolve the merge conflicts. |
crlf0710
force-pushed
the
trait_upcasting_part1
branch
from
4b7453d to
eff21b2
Compare
crlf0710
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Member
Author
|
This is ready for review now. |
crlf0710
force-pushed
the
trait_upcasting_part1
branch
from
eff21b2 to
a9ed43a
Compare
Collaborator
|
✌️ @crlf0710 can now approve this pull request |
Collaborator
|
☔ The latest upstream changes (presumably #87237) made this pull request unmergeable. Please resolve the merge conflicts. |
crlf0710
force-pushed
the
trait_upcasting_part1
branch
from
9e4a529 to
d60ae35
Compare
Member
Author
|
Tests added with small tweaking on the second group. |
Collaborator
|
📌 Commit d60ae35deaaee047ef186c6538bf06f198cb7cbe has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit d60ae35deaaee047ef186c6538bf06f198cb7cbe with merge c7e6df822218f6405f46012092b8f4de4840228d... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
crlf0710
force-pushed
the
trait_upcasting_part1
branch
from
d60ae35 to
a28ee25
Compare
Member
Author
|
Added |
Member
Author
|
@bors r=nikomatsakis |
Collaborator
|
📌 Commit a28ee25 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 3, 2021
Trait upcasting coercion (part2) This is the second part of trait upcasting coercion implementation. Currently this is blocked on rust-lang#86264 . The third part might be implemented using unsafety checking r? `@bjorn3`
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Aug 6, 2021
Trait upcasting coercion (part2) This is the second part of trait upcasting coercion implementation. Currently this is blocked on rust-lang#86264 . The third part might be implemented using unsafety checking r? `@bjorn3`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This revives the first part of earlier PR #60900 .
It's not very clear to me which parts of that pr was design decisions, so i decide to cut it into pieces and land them incrementally. This allows more eyes on the details.
This is the first part, it adds feature gates, adds feature gates tests, and implemented the unsize conversion part.
(I hope i have dealt with the
ExistentialTraitRefvalues correctly...)The next part will be implementing the pointer casting.