Add missing time complexities to linked_list.rs #89210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kennytm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
kennytm
reviewed
Sep 24, 2021
ghost
mentioned this pull request
|
@bors r+ rollup |
|
📌 Commit cebba31 has been approved by |
bors
added
S-waiting-on-bors
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 24, 2021
Add missing time complexities to linked_list.rs Most functions in LinkedList have time complexities in their description: Like push front: ``` Adds an element first in the list. This operation should compute in O(1) time. ``` Time complexities were missing for the following, so I've added them in this PR: contains: O(n) front: O(1) front_mut: O(1) back: O(1) back_mut: O(1)
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 24, 2021
Add missing time complexities to linked_list.rs Most functions in LinkedList have time complexities in their description: Like push front: ``` Adds an element first in the list. This operation should compute in O(1) time. ``` Time complexities were missing for the following, so I've added them in this PR: contains: O(n) front: O(1) front_mut: O(1) back: O(1) back_mut: O(1)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 25, 2021
…ingjubilee Rollup of 8 pull requests Successful merges: - rust-lang#88893 (Add 1.56.0 release notes) - rust-lang#89001 (Be explicit about using Binder::dummy) - rust-lang#89072 (Avoid a couple of Symbol::as_str calls in cg_llvm ) - rust-lang#89104 (Simplify scoped_thread) - rust-lang#89208 ([rfc 2229] Drop fully captured upvars in the same order as the regular drop code) - rust-lang#89210 (Add missing time complexities to linked_list.rs) - rust-lang#89217 (Enable "generate-link-to-definition" option on rust tools docs as well) - rust-lang#89221 (Give better error for `macro_rules! name!`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
|
@Takashiidobe don't modify the PR after it has been approved. The original changes has already been rolled up into #89230 and merged. please file a new PR for fa1a878. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Sep 26, 2021
Consistent big O notation This makes the big O time complexity notation in places with markdown support more consistent. Inspired by rust-lang#89210
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Sep 28, 2021
Consistent big O notation This makes the big O time complexity notation in places with markdown support more consistent. Inspired by rust-lang#89210
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most functions in LinkedList have time complexities in their description:
Like push front:
Time complexities were missing for the following, so I've added them in this PR:
contains: O(n)
front: O(1)
front_mut: O(1)
back: O(1)
back_mut: O(1)