Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue link for explaining that why rustc_private linker fails #2268

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Add issue link for explaining that why rustc_private linker fails #2268

merged 1 commit into from
Mar 18, 2025

Conversation

xizheyin
Copy link
Contributor

@xizheyin xizheyin commented Mar 5, 2025

@xizheyin xizheyin mentioned this pull request Mar 10, 2025
Merged
@jieyouxu jieyouxu added S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content T-compiler Relevant to compiler team S-waiting-on-author Status: this PR is waiting for additional action by the OP and removed S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content labels Mar 10, 2025
@xizheyin xizheyin requested a review from jieyouxu March 18, 2025 07:22
jieyouxu
jieyouxu approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, two nits

jieyouxu
jieyouxu approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you squash the commits into one?

@xizheyin
Copy link
Contributor Author

Sure, it is done. : ) @jieyouxu

@jieyouxu
Copy link
Member

Cool

@jieyouxu jieyouxu merged commit c3b9e8a into rust-lang:master Mar 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees
No one assigned
Labels
S-waiting-on-author Status: this PR is waiting for additional action by the OP T-compiler Relevant to compiler team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rustc_private linker error when llvm-tools is not installed
2 participants
@xizheyin @jieyouxu