Skip to content

Fix bootstrap rustc benchmark #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
+9 −1
Merged

Fix bootstrap rustc benchmark #2051

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c608270
Produce an error when rustc benchmark produces no timing data
Kobzol Mar 4, 2025
522533c
Actually build the compiler in bootstrap benchmark
Kobzol Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion collector/src/compile/execute/rustc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ async fn record(
.env("BOOTSTRAP_SKIP_TARGET_SANITY", "1")
.arg("build")
.arg("--stage")
.arg("0")
.arg("1")
// We want bootstrap and the Cargos it spawns to have no parallelism --
// if multiple rustcs are competing for jobserver tokens, we introduce
// quite a bit of variance.
Expand All @@ -144,6 +144,14 @@ async fn record(
}
}

// Sanity check
if timing_data.is_empty() {
return Err(anyhow::anyhow!(
"rustc benchmark failed to produce timing data\nSTDOUT:\n{}\n\nSTDERR:{timings}\n",
String::from_utf8_lossy(&output.stdout)
));
}

let version = get_rustc_perf_commit();
let collection = conn.collection_id(&version).await;

Expand Down
Loading