Feat; Create new table for collector configuration #2157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
reviewed
Jun 11, 2025
Kobzol
reviewed
Jun 11, 2025
There was a problem hiding this comment.
Thanks! I think that the table looks good like it is, but also I don't think we necessarily need to merge this outright.
So I'd keep this lying here until we have some actual code (probably first in the website) that actually needs to use this table, and then write the corresponding DbPool queries so that we have a user of the table. Maybe we'll figure out that we need some additional columns by then or something.
Kobzol
reviewed
Jun 18, 2025
Jamesbarford
force-pushed
the
feat/collector-config-table
branch
2 times, most recently
from
befcbe8 to
4efc625
Compare
7 tasks
Jamesbarford
force-pushed
the
feat/collector-config-table
branch
from
4efc625 to
adc0417
Compare
Jamesbarford
force-pushed
the
feat/collector-config-table
branch
from
adc0417 to
e8b9121
Compare
Kobzol
reviewed
Jul 14, 2025
Kobzol
reviewed
Jul 17, 2025
Jamesbarford
force-pushed
the
feat/collector-config-table
branch
from
ad866ba to
2e7ced8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a table for collector configuration; storing the target, whether the collector is
activeand able to take work. Has a heartbeat column so we can see if the collector goes offline.benchmark_setis for when we start splitting work between collectors