Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement int extension #552

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sapir
Copy link
Contributor

@sapir sapir commented Aug 5, 2024

I tried to fix the FIXME in zext. Would this be acceptable?

Also, how should I add tests?

@antoyo
Copy link
Contributor

antoyo commented Aug 9, 2024

For the test, you can either add it to this file or you can create another file in that directory.

@antoyo
Copy link
Contributor

antoyo commented Oct 8, 2024

Did you want to add a test or would you want to merge this as is?

@sapir
Copy link
Contributor Author

sapir commented Oct 13, 2024

I did try to add a test and found that the test passes either way, so maybe I should change the PR to just add the test instead of changing the code?

@antoyo
Copy link
Contributor

antoyo commented Oct 13, 2024

You mean, to make sure the test fails without the implementation of int extension?
If so, yes, you can push a test, remove the implementation to make sure the test fails and push back the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants