Skip to content

fix: wrap function without a body exceeding 100 characters (#6539) #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions src/items.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2500,6 +2500,7 @@ fn rewrite_fn_base(
ret_str_len,
fn_brace_style,
multi_line_ret_str,
where_clause,
);

debug!(
Expand Down Expand Up @@ -2602,10 +2603,20 @@ fn rewrite_fn_base(
// the closing parenthesis of the param and the arrow '->' is considered.
let mut sig_length = result.len() + indent.width() + ret_str_len + 1;

// If there is no where-clause, take into account the space after the return type
// and the brace.
// If there is no where-clause.
if where_clause.predicates.is_empty() {
sig_length += 2;
if context.config.style_edition() >= StyleEdition::Edition2027 {
let line_ending_overhead = match fn_brace_style {
FnBraceStyle::NextLine => 0, // No brace to account for
FnBraceStyle::SameLine => 2, // Trailing space and brace, e.g. ` {`
FnBraceStyle::None => 1, // Trailing `;`
};
sig_length += line_ending_overhead;
} else {
// Take into account the space after the return type and the brace.
// 2 = ' {'
sig_length += 2;
}
}

sig_length > context.config.max_width()
Expand Down Expand Up @@ -2889,6 +2900,7 @@ fn compute_budgets_for_params(
ret_str_len: usize,
fn_brace_style: FnBraceStyle,
force_vertical_layout: bool,
where_clause: &ast::WhereClause,
) -> (usize, usize, Indent) {
debug!(
"compute_budgets_for_params {} {:?}, {}, {:?}",
Expand All @@ -2903,7 +2915,15 @@ fn compute_budgets_for_params(
let overhead = if ret_str_len == 0 { 2 } else { 3 };
let mut used_space = indent.width() + result.len() + ret_str_len + overhead;
match fn_brace_style {
FnBraceStyle::None => used_space += 1, // 1 = `;`
_ if context.config.style_edition() >= StyleEdition::Edition2027
&& where_clause.predicates.len() > 0 =>
{
// Don't add anything to `used_space` if we have a where clause.
// For all `FnBraceStyle` values if we have a where cluase that can't fit
// on the current line it'll be written to the next line.
// Therefore, we don't need to account for a trailing `;` or `{}`
}
FnBraceStyle::None => used_space += 1, // 1 = `;`
FnBraceStyle::SameLine => used_space += 2, // 2 = `{}`
FnBraceStyle::NextLine => (),
}
Expand Down
16 changes: 16 additions & 0 deletions tests/source/issue-6539/brace_next_line.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// rustfmt-style_edition: 2027
// rustfmt-brace_style: AlwaysNextLine
// rustfmt-where_single_line: false

pub trait Trait
{
fn a_one_hundred_column_fn_decl_no_body(&self, aaa: f64, b: f64, c: f64, d: f64, e: f64) -> f64;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause<T>(&self, a: T, bb: f64) -> f64 where T: Debug;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause2<T>(&self, aaa: T, bbb: f64) -> f64 where T: Debug;

fn an_over_one_hundred_column_fn_decl_with_body(&self, aaaaa: f64, bbbbb: f64, ccc: f64) -> f64 {}

fn an_over_one_hundred_column_fn_decl_with_body_and_where_clause<T>(&self, aaaaa: f64) -> f64 where T: Debug {}
}
16 changes: 16 additions & 0 deletions tests/source/issue-6539/brace_next_line_where_single_line.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// rustfmt-style_edition: 2027
// rustfmt-brace_style: AlwaysNextLine
// rustfmt-where_single_line: true

pub trait Trait
{
fn a_one_hundred_column_fn_decl_no_body(&self, aaa: f64, b: f64, c: f64, d: f64, e: f64) -> f64;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause<T>(&self, a: T, bb: f64) -> f64 where T: Debug;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause2<T>(&self, aaa: T, bbb: f64) -> f64 where T: Debug;

fn an_over_one_hundred_column_fn_decl_with_body(&self, aaaaa: f64, bbbbb: f64, ccc: f64) -> f64 {}

fn an_over_one_hundred_column_fn_decl_with_body_and_where_clause<T>(&self, aaaaa: f64) -> f64 where T: Debug {}
}
15 changes: 15 additions & 0 deletions tests/source/issue-6539/default.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// rustfmt-style_edition: 2027

pub trait Trait {
fn a_one_hundred_column_fn_decl_no_body(&self, aaa: f64, b: f64, c: f64, d: f64, e: f64) -> f64;

fn a_one_hundred_one_column_fn_decl_no_body(self, a: f64, b: f64, c: f64, d: f64, e: f64) -> f64;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause<T>(&self, a: T, bb: f64) -> f64 where T: Debug;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause2<T>(&self, aaa: T, bbb: f64) -> f64 where T: Debug;

fn an_over_one_hundred_column_fn_decl_with_body(&self, aaaaa: f64, bbbbb: f64, ccc: f64) -> f64 {}

fn an_over_one_hundred_column_fn_decl_with_body_and_where_clause<T>(&self, aaaaa: f64) -> f64 where T: Debug {}
}
30 changes: 30 additions & 0 deletions tests/target/issue-6539/brace_next_line.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
// rustfmt-style_edition: 2027
// rustfmt-brace_style: AlwaysNextLine
// rustfmt-where_single_line: false

pub trait Trait
{
fn a_one_hundred_column_fn_decl_no_body(&self, aaa: f64, b: f64, c: f64, d: f64, e: f64) -> f64;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause<T>(&self, a: T, bb: f64) -> f64
where
T: Debug;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause2<T>(
&self,
aaa: T,
bbb: f64,
) -> f64
where
T: Debug;

fn an_over_one_hundred_column_fn_decl_with_body(&self, aaaaa: f64, bbbbb: f64, ccc: f64) -> f64
{
}

fn an_over_one_hundred_column_fn_decl_with_body_and_where_clause<T>(&self, aaaaa: f64) -> f64
where
T: Debug,
{
}
}
28 changes: 28 additions & 0 deletions tests/target/issue-6539/brace_next_line_where_single_line.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
// rustfmt-style_edition: 2027
// rustfmt-brace_style: AlwaysNextLine
// rustfmt-where_single_line: true

pub trait Trait
{
fn a_one_hundred_column_fn_decl_no_body(&self, aaa: f64, b: f64, c: f64, d: f64, e: f64) -> f64;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause<T>(&self, a: T, bb: f64) -> f64
where T: Debug;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause2<T>(
&self,
aaa: T,
bbb: f64,
) -> f64
where
T: Debug;

fn an_over_one_hundred_column_fn_decl_with_body(&self, aaaaa: f64, bbbbb: f64, ccc: f64) -> f64
{
}

fn an_over_one_hundred_column_fn_decl_with_body_and_where_clause<T>(&self, aaaaa: f64) -> f64
where T: Debug
{
}
}
40 changes: 40 additions & 0 deletions tests/target/issue-6539/default.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
// rustfmt-style_edition: 2027

pub trait Trait {
fn a_one_hundred_column_fn_decl_no_body(&self, aaa: f64, b: f64, c: f64, d: f64, e: f64) -> f64;

fn a_one_hundred_one_column_fn_decl_no_body(
self,
a: f64,
b: f64,
c: f64,
d: f64,
e: f64,
) -> f64;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause<T>(&self, a: T, bb: f64) -> f64
where
T: Debug;

fn an_over_one_hundred_column_fn_decl_no_body_and_where_clause2<T>(
&self,
aaa: T,
bbb: f64,
) -> f64
where
T: Debug;

fn an_over_one_hundred_column_fn_decl_with_body(
&self,
aaaaa: f64,
bbbbb: f64,
ccc: f64,
) -> f64 {
}

fn an_over_one_hundred_column_fn_decl_with_body_and_where_clause<T>(&self, aaaaa: f64) -> f64
where
T: Debug,
{
}
}
Loading