Skip to content

Log versions during self updates #4331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

Log versions during self updates #4331

merged 2 commits into from
May 19, 2025

Conversation

djc
Copy link
Contributor

@djc djc commented May 12, 2025

Fixes #4327.

@djc djc requested review from ChrisDenton and rami3l May 12, 2025 13:56
Copy link
Member

@rami3l rami3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot :)

@djc djc force-pushed the self-update-versions branch 2 times, most recently from 550897e to 4432cbe Compare May 14, 2025 10:46
@rami3l
Copy link
Member

rami3l commented May 17, 2025

I just noticed that during rustup self update we already have this message:

rustup/src/cli/self_update.rs

Lines 1063 to 1067 in 7ba0abf

let _ = common::show_channel_update(
cfg,
PackageUpdate::Rustup,
Ok(UpdateStatus::Updated(version)),
);

... so it might be interesting to just reuse that logic here.

@djc djc force-pushed the self-update-versions branch from 4432cbe to b039999 Compare May 19, 2025 10:25
@djc
Copy link
Contributor Author

djc commented May 19, 2025

I just noticed that during rustup self update we already have this message:

I noticed that too, but I think just showing these versions as soon as we have them is probably better.

@djc djc force-pushed the self-update-versions branch from b039999 to 896c6a7 Compare May 19, 2025 10:35
@djc djc added this pull request to the merge queue May 19, 2025
Merged via the queue into master with commit e6ecdf5 May 19, 2025
29 checks passed
@djc djc deleted the self-update-versions branch May 19, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-update does not report the new version downloaded
2 participants