feat(rustup-mode): add no_update flag to rustup toolchain install
#4522
+57
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Oct 10, 2025
This comment was marked as resolved.
This comment was marked as resolved.
nozwock
commented
Oct 10, 2025
nozwock
force-pushed
the
add-install-no-update
branch
from
72a95f6 to
4192bf4
Compare
|
Need to update the |
nozwock
force-pushed
the
add-install-no-update
branch
2 times, most recently
from
6234419 to
c7c20dc
Compare
Oh I see, I forgot to run all the tests before, only ran I just regenerated the help output svg, not sure if something else needs to be done. |
|
@nozwock do you mind also squashing the test output change into the first commit? Would be nice to have each commit in our branch history pass tests (as far as possible). |
nozwock
force-pushed
the
add-install-no-update
branch
from
c7c20dc to
f09795e
Compare
|
@djc I see, didn't think of that. Just did it. |
djc
approved these changes
Nov 4, 2025
|
@rami3l want to take a look? |
nozwock
force-pushed
the
add-install-no-update
branch
from
f09795e to
0caa14c
Compare
nozwock
force-pushed
the
add-install-no-update
branch
from
0caa14c to
de3785e
Compare
|
Rebased. Did |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4505. Adding a flag to don't try to update already installed toolchains.