Stabilize runtime detection of VEX variants of avx512 #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayantn
force-pushed
the
vex-change-temporary
branch
2 times, most recently
from
3e219eb to
f0e1f9a
Compare
sayantn
force-pushed
the
vex-change-temporary
branch
from
f0e1f9a to
9b7775a
Compare
sayantn
force-pushed
the
vex-change-temporary
branch
from
9b7775a to
9adc113
Compare
traviscross
reviewed
May 17, 2025
Comment on lines
-206
to
+214
| @FEATURE: #[unstable(feature = "x86_amx_intrinsics", issue = "44839")] avxifma: "avxifma"; | ||
| @FEATURE: #[stable(feature = "avx512_target_feature", since = "1.88.0")] avxifma: "avxifma"; | ||
| /// AVX-IFMA (Integer Fused Multiply Add) | ||
| @FEATURE: #[unstable(feature = "x86_amx_intrinsics", issue = "44839")] avxneconvert: "avxneconvert"; | ||
| @FEATURE: #[stable(feature = "avx512_target_feature", since = "1.88.0")] avxneconvert: "avxneconvert"; | ||
| /// AVX-NE-CONVERT (Exceptionless Convert) | ||
| @FEATURE: #[unstable(feature = "x86_amx_intrinsics", issue = "44839")] avxvnni: "avxvnni"; | ||
| @FEATURE: #[stable(feature = "avx512_target_feature", since = "1.88.0")] avxvnni: "avxvnni"; | ||
| /// AVX-VNNI (Vector Neural Network Instructions) | ||
| @FEATURE: #[unstable(feature = "x86_amx_intrinsics", issue = "44839")] avxvnniint16: "avxvnniint16"; | ||
| @FEATURE: #[stable(feature = "avx512_target_feature", since = "1.88.0")] avxvnniint16: "avxvnniint16"; | ||
| /// AVX-VNNI_INT8 (VNNI with 16-bit Integers) | ||
| @FEATURE: #[unstable(feature = "x86_amx_intrinsics", issue = "44839")] avxvnniint8: "avxvnniint8"; | ||
| @FEATURE: #[stable(feature = "avx512_target_feature", since = "1.88.0")] avxvnniint8: "avxvnniint8"; |
There was a problem hiding this comment.
It's going to make Rust 1.89 rather than Rust 1.88 at this point.
There was a problem hiding this comment.
Ah, I will correct it tonight. CURRENT_RUSTC_VERSION not working inside submodules is mildly infuriating sometimes 😅
|
@Amanieu wait, the versions need to be updated as @traviscross pointed out |
|
Ok lol nvm, I will send another PR to update that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stabilizes the runtime detection of the following target features
avxvnniavxifmaavxvnniint8avxvnniint16avxneconvert