Skip to content

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented Sep 2, 2025

We have a mechanism (see 2556583) that auto-nominates pull requests for a backport if they fix a P-high/P-critical regression.

@jieyouxu suggested in this Zulip comment to exclude pull requests drafts from this mechanism (which makes sense), so this patch implements this suggestion.

r? @jieyouxu

thanks for a review :)

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense, though I'm not super familiar with triagebot's codebase so rolling a triagebot reviewer :3

View changes since this review

@jieyouxu
Copy link
Member

jieyouxu commented Sep 2, 2025

r? triagebot

@rustbot rustbot assigned Mark-Simulacrum and unassigned jieyouxu Sep 2, 2025
@apiraino apiraino force-pushed the exclude-drafts-from-auto-backport-nominate branch from 31cc5f1 to 68de8c8 Compare September 2, 2025 10:56
Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what should happen when the PR is undrafted - should this handler run to check for backports? If yes, then we might want to add IssuesAction::ReadyForReview, because I don't think that Edited runs when the PR is converted away from a draft.

View changes since this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants