Skip to content

Conversation

@Urgau
Copy link
Member

@Urgau Urgau commented Dec 8, 2025

Some people continue to post on closed major change despite our messages not to do so.

Let's be more decisive and lock the issue once the major change has been accepted (we tried locking from the started but that had to be reverted #1876).

cf. rust-lang/compiler-team#932 (comment)
cc @apiraino

@Urgau Urgau requested a review from Kobzol December 8, 2025 17:10
@Kobzol
Copy link
Member

Kobzol commented Dec 8, 2025

Have you tried if closed issues can be locked through the API? Just something that came to mind. Other than that LGTM, but I'd like to hear what apiraino thinks.

@apiraino
Copy link
Contributor

apiraino commented Dec 8, 2025

What changed since the last time we decided to revert the lock?

@Urgau
Copy link
Member Author

Urgau commented Dec 8, 2025

Have you tried if closed issues can be locked through the API?

I haven't, but I see no reason it wouldn't work.

What changed since the last time we decided to revert the lock?

People started posting on closed MCP (see rust-lang/compiler-team#932 (comment) or rust-lang/compiler-team#920 (comment)), and last time we lock the issue but did it from the start (which caused issue for non org PR author members), this proposal only does it after it's closed/accepted which doesn't have the same issue.

@apiraino
Copy link
Contributor

apiraino commented Dec 9, 2025

By looking at compiler-team#920, I wonder what happens to issues crosslinking/mentions: can a locked GitHub issue show when it is referenced somewhere else?

Other than that, I am mostly neutral about this change - we can try it if you feel strongly about it.

@Urgau
Copy link
Member Author

Urgau commented Dec 9, 2025

can a locked GitHub issue show when it is referenced somewhere else?

Yes, the two thing that locking prevents is commenting and using emojis on it. Mentions still works as expected.

we can try it if you feel strongly about it

I wouldn't say I feel "strongly" — "frustrated" might be a better word, posting on an old issue should never be done, in particular for MCP where we have a dedicated place to discuss those.

I don't see any harm in trying it, let's see how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants