Skip to content

fix(i18n): home page footer layout overflow error #2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

iusx
Copy link
Contributor

@iusx iusx commented May 4, 2025

error page

url:https://www.rust-lang.org/ru/
windows width size: 500

Mozilla/5.0 (Linux; Android 6.0; Nexus 5 Build/MRA58N) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Mobile Safari/537.36

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:136.0) Gecko/20100101 Firefox/136.0
image

This pr page

image

@iusx iusx requested a review from a team as a code owner May 4, 2025 11:50
@senekor
Copy link
Contributor

senekor commented May 4, 2025

I like this. l is the breakpoint where a lot of the other content switches between one and several columns.

@iusx
Copy link
Contributor Author

iusx commented May 5, 2025

I like this. l is the breakpoint where a lot of the other content switches between one and several columns.

Yes, using flex-row-l can accommodate more languages. flex-row-ns might not cause overflow in English, but switching to Russian or other languages could potentially lead to overflow issues.

-         <div class="flex flex-column flex-row-ns pv0-l">
+         <div class="flex flex-column flex-row-l pv0-l">

@senekor senekor merged commit ad89f20 into rust-lang:master May 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants